Skip to content

Surface "synthetic" test passing to the reporters #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natebosch opened this issue Dec 15, 2020 · 0 comments
Open

Surface "synthetic" test passing to the reporters #1402

natebosch opened this issue Dec 15, 2020 · 0 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@natebosch
Copy link
Member

We currently hide tests that are "synthetic" after they pass.

} else if (countSuccess) {
_passed.add(liveTest);
// A passing test that was once failing was retried
_failed.remove(liveTest);
}

We want to surface failures and since we don't have another test to associate them with, we report failures under a new test. A human doesn't need to see that they passed, but a machine might want to see this, especially following a run where it failed. It's better to model as a passing test than as a disappearing (previously failing) test.

This could likely get wrapped in with #1311

@natebosch natebosch added the type-enhancement A request for a change that isn't a bug label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant