Skip to content

Move Matcher implementations to separate package #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seaneagan opened this issue Apr 1, 2015 · 2 comments
Closed

Move Matcher implementations to separate package #2326

seaneagan opened this issue Apr 1, 2015 · 2 comments

Comments

@seaneagan
Copy link
Contributor

This package (matcher) could simply define the interfaces and default implementation.
It would be very easy to get such a package to stabilize to 1.0.0 and keep it there.
The test package and other packages which want to define a Matcher based API, such as constrain, would depend on matcher.

The Matcher implementations currently in this package could be moved to a separate matchers package which contains all the Matcher implementations which are currently in matcher, and it would be what users of test and other Matcher-based APIs would import. That would give the freedom to continue making breaking changes to these implementations, without it being a big deal, since it's only depended on by essentially end users.

This package could re-export the matchers package for a period of time, but that re-export would be deprecated. Is it possible to mark an export as deprecated?

@deprecated
export package:matchers/matchers.dart;
@seaneagan
Copy link
Contributor Author

Filed a bug for deprecated exports.

@nex3
Copy link
Member

nex3 commented Apr 1, 2015

I don't think this would provide a huge amount of benefit. matcher very rarely has breaking changes, and when it does they're usually tightly coupled to breaking changes in unittest anyway. Not only that, most of the uses of matcher through unittest are as leaf nodes on the package graph, and there aren't any plans to release breaking changes for a long time after unittest and matcher 1.0.0.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants