Skip to content

Feature Request: print number of tests skipped #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliemr opened this issue Jul 20, 2015 · 2 comments
Closed

Feature Request: print number of tests skipped #292

juliemr opened this issue Jul 20, 2015 · 2 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@juliemr
Copy link

juliemr commented Jul 20, 2015

It would be nice to know if some test files were skipped because they were not on the correct platform.

@nex3
Copy link
Member

nex3 commented Jul 20, 2015

This is more or less what the @Skip annotation is for: skipping tests visibly. I think it would mostly just be distracting if all tests whose platforms didn't match produced visible output. Also, it's not really possible to do accurately; we need to load the test file to determine what tests it defines, and it's not possible to load a test that imports dart:io on the browser or dart:html in the VM.

If you want to make sure you're running on all the relevant platforms, #46 will allow you to define which ones get used by default.

@nex3 nex3 closed this as completed Jul 20, 2015
@nex3 nex3 added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jul 20, 2015
@juliemr
Copy link
Author

juliemr commented Jul 20, 2015

I don't know, it seems to me that without a warning, it would be very easy to miss a failure that you introduced but didn't actually run the tests for. I'd be happy with a warning that there were some tests that were skipped, without needing to actually parse the file to get a number.

Sounds like #46 could take care of making sure that a random contributor (or normal contributor who is distracted) doesn't accidentally miss some command line flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

2 participants