Skip to content

Master fails with Dart VM version: 2.0.0-dev.39.0 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grouma opened this issue Mar 19, 2018 · 6 comments
Closed

Master fails with Dart VM version: 2.0.0-dev.39.0 #788

grouma opened this issue Mar 19, 2018 · 6 comments
Assignees
Labels
status-blocked Blocked from making progress by another (referenced) issue

Comments

@grouma
Copy link
Member

grouma commented Mar 19, 2018

Failures appear to be Dart2JS related. Likely need to use the old frontend. See https://travis-ci.org/dart-lang/test/builds/354771199

@grouma grouma self-assigned this Mar 19, 2018
@natebosch
Copy link
Member

Using the old frontend is a good temporary fix to get unblocked. Longer term we'll want to make sure we're using arguments compatible with the latest Dart2Js approach.

@nex3
Copy link
Member

nex3 commented Mar 19, 2018

I believe this is caused by dart-lang/sdk#32561, which means it should be fixed with the next dev SDK roll.

@natebosch
Copy link
Member

Can we rely on PackageResolver.current.processArgument always choosing --package instead of --package-root?

I wasn't sure if all the failures where with --pub-serve or not

@nex3
Copy link
Member

nex3 commented Mar 19, 2018

Can we rely on PackageResolver.current.processArgument always choosing --package instead of --package-root?

As long as it never depends on transformed code, it should be fine. If it is being run using a package root, there's not going to be any valid way of invoking dart2js.

I wasn't sure if all the failures where with --pub-serve or not

I didn't do a thorough check but it looked like they were at a glance.

@natebosch
Copy link
Member

Initial workaround: #793

Still need to figure out a better long term solution

@nex3
Copy link
Member

nex3 commented Mar 22, 2018

Once dart-lang/sdk#32633 is fixed (which it should be soon; it's marked P1 and there's a lot of activity around it) we'll be fine here.

@nex3 nex3 added the status-blocked Blocked from making progress by another (referenced) issue label Mar 22, 2018
@grouma grouma closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
Development

No branches or pull requests

3 participants