Skip to content

--precompiled vm tests can't easily read from the precompiled directory #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue Apr 10, 2018 · 1 comment
Closed
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@jakemac53
Copy link
Contributor

The working directory of the isolate is the same as the main dart process, meaning the root package directory. If you want to read generated files (goldens, etc), you need to know where those files are generated.

Ideally we would either be able to change the working directory or at least expose a path to the precompiled directory for tests to read from.

@jakemac53 jakemac53 added the type-enhancement A request for a change that isn't a bug label Apr 10, 2018
@natebosch natebosch added the closed-duplicate Closed in favor of an existing report label Feb 22, 2023
@natebosch
Copy link
Member

I think we should consider this a duplicate of #110

I think if we had an API for reading files from a standard location we could make it work for precompiled tests automatically. We could even make it work to have multiple search directories for the files, and read from either the precompiled output or package source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants