Skip to content

Re-enable pub-serve tests or delete the feature #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue May 2, 2018 · 9 comments
Closed

Re-enable pub-serve tests or delete the feature #821

jakemac53 opened this issue May 2, 2018 · 9 comments
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump

Comments

@jakemac53
Copy link
Contributor

The tests are now going to be skipped since the latest sdk doesn't support pub serve.

We can either delete the feature entirely, or do some other sort of test (possibly use build_runner serve).

@jakemac53
Copy link
Contributor Author

If we do retain the flag we should probably rename it as well (although we can support the old version as an alias).

@kevmoo
Copy link
Member

kevmoo commented May 18, 2018

@jakemac53 @grouma We removed all of this, right?

@jakemac53
Copy link
Contributor Author

This support still exists - we just can't test it

@natebosch natebosch added the next-breaking-release Issues that are worth doing but need to wait for a breaking version bump label Jan 31, 2020
@natebosch
Copy link
Member

@jakemac53 - are we OK with removing this in the next breaking change bump?

@jakemac53
Copy link
Contributor Author

Well ironically with frontend server we might want to bring it back to official support lol

@kevmoo
Copy link
Member

kevmoo commented Feb 1, 2020

Well ironically with frontend server we might want to bring it back to official support lol

😮

@natebosch
Copy link
Member

@jakemac53 - do we think there is any use case still?

Would dropping this make the --compiler work any easier?

@jakemac53
Copy link
Contributor Author

I could definitely see dropping it, but given precompiled support has to stick around the complexity/decisions are essentially identical.

@natebosch
Copy link
Member

--pub-serve dropped in #2144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump
Projects
None yet
Development

No branches or pull requests

3 participants