-
Notifications
You must be signed in to change notification settings - Fork 219
Re-enable pub-serve tests or delete the feature #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If we do retain the flag we should probably rename it as well (although we can support the old version as an alias). |
@jakemac53 @grouma We removed all of this, right? |
This support still exists - we just can't test it |
@jakemac53 - are we OK with removing this in the next breaking change bump? |
Well ironically with frontend server we might want to bring it back to official support lol |
😮 |
@jakemac53 - do we think there is any use case still? Would dropping this make the |
I could definitely see dropping it, but given precompiled support has to stick around the complexity/decisions are essentially identical. |
|
The tests are now going to be skipped since the latest sdk doesn't support pub serve.
We can either delete the feature entirely, or do some other sort of test (possibly use build_runner serve).
The text was updated successfully, but these errors were encountered: