Merge pull request dart-archive/bazel_worker#37 from dart-lang/proper-close

grouma · web-flow · commit d0ea3c13bb13 · 2019-02-12T10:38:15.000-08:00
Close output stream on cancel
diff --git a/pkgs/bazel_worker/CHANGELOG.md b/pkgs/bazel_worker/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.1.20
+
+* Close worker `outputStream` on `cancel`.
+
 ## 0.1.19
 
 * Work around https://github.com/dart-lang/sdk/issues/35874.
diff --git a/pkgs/bazel_worker/lib/src/driver/driver_connection.dart b/pkgs/bazel_worker/lib/src/driver/driver_connection.dart
@@ -77,7 +77,10 @@ class StdDriverConnection implements DriverConnection {
   }
 
   @override
-  Future cancel() => _messageGrouper.cancel();
+  Future cancel() async {
+    await _outputStream.close();
+    await _messageGrouper.cancel();
+  }
 }
 
 /// [DriverConnection] that works with an isolate via a [SendPort].
diff --git a/pkgs/bazel_worker/pubspec.yaml b/pkgs/bazel_worker/pubspec.yaml
@@ -1,5 +1,5 @@
 name: bazel_worker
-version: 0.1.19
+version: 0.1.20
 
 description: Tools for creating a bazel persistent worker.
 author: Dart Team <misc@dartlang.org>

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,10 @@ class StdDriverConnection implements DriverConnection {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`@override`
`80`		`- Future cancel() => _messageGrouper.cancel();`
	`80`	`+ Future cancel() async {`
	`81`	`+ await _outputStream.close();`
	`82`	`+ await _messageGrouper.cancel();`
	`83`	`+ }`
`81`	`84`	`}`
`82`	`85`
`83`	`86`	`/// [DriverConnection] that works with an isolate via a [SendPort].`