Skip to content

add package:dash_analytics #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devoncarew opened this issue Feb 10, 2023 · 3 comments · Fixed by #2
Closed

add package:dash_analytics #1

devoncarew opened this issue Feb 10, 2023 · 3 comments · Fixed by #2

Comments

@devoncarew
Copy link
Member

@eliasyishak, we now have a general mono repo for Dart tooling packages. Feel free to open a PR adding dash_analytics here; you'll want to put it as a subdirectory of the pkgs/ dir. You shouldn't need to include any files from your .github dir.

This repo doesn't have a CI set up yet, but I'll do that once we have 1 package here.

@eliasyishak
Copy link
Contributor

Awesome! Thanks @devoncarew, should get a PR drafted by Monday, wrapping up some final tests

@eliasyishak
Copy link
Contributor

I've opened a PR at #2 for adding the package.

Will I also be getting write access to this repo? I've added myself in the CODEOWNER file and got a warning from github

@devoncarew
Copy link
Member Author

devoncarew commented Feb 13, 2023

We don't generally use the github CODEOWNER file for dart-lang repos (and I'm not 100% sure of what the pros and cons are myself).

The best way for you to get commit access would be to join the dart-team github team; I'll send you instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants