Skip to content

oauth2 package - pass in scope delimiter character, default to 'a single space #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request package:oauth2 type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#20418

This issue was originally filed by [email protected]


when passing in a list of scopes to get access to for a user the code currently has a hard coded scope delimiter:

      if (!scopes.isEmpty) fields["scope"] = scopes.join(' ');

would it be possible to pass in a delimiter character, as I understand it facebook uses a comma rather than a space, so I don't think it is possible to use the oauth2 package to connect with facebook for this reason.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse


Added Area-Pkg, Pkg-oauth2, Triaged labels.

@nex3
Copy link
Member

nex3 commented Jun 6, 2015

The spec mandates using a space, but I suppose I'd accept a patch that added a flag to support Facebook-style OAuth2 (see also #303).

@nex3 nex3 added contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request labels Jun 6, 2015
@thosakwe
Copy link
Contributor

This should be resolved by dart-archive/oauth2#17, if it's accepted.

@nex3 nex3 closed this as completed Jun 2, 2017
@mosuem mosuem transferred this issue from dart-archive/oauth2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request package:oauth2 type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants