Skip to content

Commit 16dbb30

Browse files
authored
Change debug extension panel name to Dart Debugger (#1511)
1 parent 9544c82 commit 16dbb30

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

dwds/debug_extension/web/devtools.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
if (isDartApp) {
2424
created = true
2525
chrome.devtools.panels.create(
26-
'Dart', '', 'panel.html'
26+
'Dart Debugger', '', 'panel.html'
2727
);
2828
}
2929
},

dwds/test/debug_extension_test.dart

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ import 'fixtures/utilities.dart';
3131
// See go/extension-identification.
3232

3333
final context = TestContext();
34+
35+
// TODO(elliette): Instead of setting a time to load, check for element on page.
36+
// See: https://github.com/dart-lang/webdev/issues/1512
37+
// Time for Dart DevTools to load, in seconds.
38+
final devToolsLoadTime = const Duration(seconds: 4);
39+
3440
void main() async {
3541
for (var useSse in [true, false]) {
3642
group(useSse ? 'SSE' : 'WebSockets', () {
@@ -42,7 +48,7 @@ void main() async {
4248
'expression': 'fakeClick()',
4349
});
4450
// Wait for DevTools to actually open.
45-
await Future.delayed(const Duration(seconds: 2));
51+
await Future.delayed(devToolsLoadTime);
4652
});
4753

4854
tearDown(() async {
@@ -70,7 +76,7 @@ void main() async {
7076
await context.extensionConnection.sendCommand('Runtime.evaluate', {
7177
'expression': 'fakeClick()',
7278
});
73-
await Future.delayed(const Duration(seconds: 4));
79+
await Future.delayed(devToolsLoadTime);
7480
var windows = await context.webDriver.windows.toList();
7581
await context.webDriver.driver.switchTo.window(windows.last);
7682
expect(await context.webDriver.title, 'Dart DevTools');
@@ -122,7 +128,7 @@ void main() async {
122128
'expression': 'fakeClick()',
123129
});
124130
// Wait for DevTools to actually open.
125-
await Future.delayed(const Duration(seconds: 2));
131+
await Future.delayed(devToolsLoadTime);
126132
});
127133

128134
tearDown(() async {
@@ -148,7 +154,7 @@ void main() async {
148154
await context.extensionConnection.sendCommand('Runtime.evaluate', {
149155
'expression': 'fakeClick()',
150156
});
151-
await Future.delayed(const Duration(seconds: 4));
157+
await Future.delayed(devToolsLoadTime);
152158
var windows = await context.webDriver.windows.toList();
153159
await context.webDriver.driver.switchTo.window(windows.last);
154160
expect(await context.webDriver.title, 'Dart DevTools');

0 commit comments

Comments
 (0)