Skip to content

Commit 44b39a9

Browse files
authored
Prepare DWDS 16.0.2 for hotfix into Flutter to fix flutter_tools crash (#1867)
1 parent cb06447 commit 44b39a9

File tree

8 files changed

+257
-277
lines changed

8 files changed

+257
-277
lines changed

.github/workflows/dart.yml

Lines changed: 185 additions & 219 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 16.0.2
2+
- Don't complete an already completed `Completer` in `ChromeProxyService` to fix
3+
Flutter tools crash: https://github.com/dart-lang/webdev/pull/1862
4+
15
## 16.0.1
26

37
- Allow the following API to return `null` and add error handling:

dwds/lib/src/injected/client.js

Lines changed: 58 additions & 52 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/lib/src/services/chrome_proxy_service.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,13 @@ class ChromeProxyService implements VmServiceInterface {
257257

258258
unawaited(appConnection.onStart.then((_) async {
259259
await debugger.resumeFromStart();
260-
_startedCompleter.complete();
260+
if (!_startedCompleter.isCompleted) {
261+
_startedCompleter.complete();
262+
} else {
263+
// See https://github.com/flutter/flutter/issues/117676:
264+
_logger
265+
.warning('Unexpected state, debugging may not work as expected.');
266+
}
261267
}));
262268

263269
unawaited(appConnection.onDone.then((_) => destroyIsolate()));

dwds/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/mono_pkg.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ stages:
1515
- command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
1616
- test:
1717
sdk:
18-
- dev
1918
- stable
2019
- test:
2120
os: windows
2221
sdk:
23-
- dev
2422
- stable
2523
- beta_cron:
2624
- analyze: .

dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 16.0.1
3+
version: 16.0.2
44
description: >-
55
A service that proxies between the Chrome debug protocol and the Dart VM
66
service protocol.

tool/ci.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)