Skip to content

Commit 71d3a14

Browse files
committed
[webdev] Skip cases in webdev/test/e2e_test.dart that are failing on Windows
1 parent 8f937ff commit 71d3a14

File tree

1 file changed

+61
-46
lines changed

1 file changed

+61
-46
lines changed

webdev/test/e2e_test.dart

Lines changed: 61 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -99,68 +99,83 @@ void main() {
9999
await process.shouldExit(isNot(0));
100100
});
101101

102-
test('build should allow passing extra arguments to build_runner', () async {
103-
var args = [
104-
'build',
105-
'-o',
106-
'web:${d.sandbox}',
107-
'--',
108-
'--delete-conflicting-outputs'
109-
];
102+
test(
103+
'build should allow passing extra arguments to build_runner',
104+
() async {
105+
var args = [
106+
'build',
107+
'-o',
108+
'web:${d.sandbox}',
109+
'--',
110+
'--delete-conflicting-outputs'
111+
];
110112

111-
var process = await testRunner.runWebDev(args,
112-
workingDirectory: soundExampleDirectory);
113+
var process = await testRunner.runWebDev(args,
114+
workingDirectory: soundExampleDirectory);
113115

114-
await checkProcessStdout(process, ['Succeeded']);
115-
await process.shouldExit(0);
116-
});
116+
await checkProcessStdout(process, ['Succeeded']);
117+
await process.shouldExit(0);
118+
},
119+
// https://github.com/dart-lang/webdev/issues/2489,
120+
skip: Platform.isWindows,
121+
);
117122

118123
group('should build with valid configuration', () {
119124
for (var withDDC in [true, false]) {
120-
test(withDDC ? 'DDC' : 'dart2js', () async {
121-
var args = ['build', '-o', 'web:${d.sandbox}'];
122-
if (withDDC) {
123-
args.add('--no-release');
124-
}
125+
test(
126+
withDDC ? 'DDC' : 'dart2js',
127+
() async {
128+
var args = ['build', '-o', 'web:${d.sandbox}'];
129+
if (withDDC) {
130+
args.add('--no-release');
131+
}
125132

126-
var process = await testRunner.runWebDev(args,
127-
workingDirectory: soundExampleDirectory);
133+
var process = await testRunner.runWebDev(args,
134+
workingDirectory: soundExampleDirectory);
128135

129-
var expectedItems = <Object>['Succeeded'];
136+
var expectedItems = <Object>['Succeeded'];
130137

131-
await checkProcessStdout(process, expectedItems);
132-
await process.shouldExit(0);
138+
await checkProcessStdout(process, expectedItems);
139+
await process.shouldExit(0);
133140

134-
for (var entry in _testItems.entries) {
135-
var shouldExist = (entry.value ?? withDDC) == withDDC;
141+
for (var entry in _testItems.entries) {
142+
var shouldExist = (entry.value ?? withDDC) == withDDC;
136143

137-
if (shouldExist) {
138-
await d.file(entry.key, isNotEmpty).validate();
139-
} else {
140-
await d.nothing(entry.key).validate();
144+
if (shouldExist) {
145+
await d.file(entry.key, isNotEmpty).validate();
146+
} else {
147+
await d.nothing(entry.key).validate();
148+
}
141149
}
142-
}
143-
});
150+
},
151+
// https://github.com/dart-lang/webdev/issues/2489
152+
skip: Platform.isWindows && withDDC,
153+
);
144154
}
145-
test('and --null-safety=sound', () async {
146-
var args = [
147-
'build',
148-
'-o',
149-
'web:${d.sandbox}',
150-
'--no-release',
151-
'--null-safety=sound'
152-
];
155+
test(
156+
'and --null-safety=sound',
157+
() async {
158+
var args = [
159+
'build',
160+
'-o',
161+
'web:${d.sandbox}',
162+
'--no-release',
163+
'--null-safety=sound'
164+
];
153165

154-
var process = await testRunner.runWebDev(args,
155-
workingDirectory: soundExampleDirectory);
166+
var process = await testRunner.runWebDev(args,
167+
workingDirectory: soundExampleDirectory);
156168

157-
var expectedItems = <Object>['Succeeded'];
169+
var expectedItems = <Object>['Succeeded'];
158170

159-
await checkProcessStdout(process, expectedItems);
160-
await process.shouldExit(0);
171+
await checkProcessStdout(process, expectedItems);
172+
await process.shouldExit(0);
161173

162-
await d.file('main.ddc.js', isNotEmpty).validate();
163-
});
174+
await d.file('main.ddc.js', isNotEmpty).validate();
175+
},
176+
// https://github.com/dart-lang/webdev/issues/2489
177+
skip: Platform.isWindows,
178+
);
164179
});
165180

166181
group('should build with --output=NONE', () {

0 commit comments

Comments
 (0)