Fix TestSdkConfigurationProvider.dispose (#2308)

derekxu16 · web-flow · commit 7543345873b4 · 2023-12-18T08:58:20.000-05:00
diff --git a/test_common/lib/test_sdk_configuration.dart b/test_common/lib/test_sdk_configuration.dart
@@ -80,7 +80,9 @@ class TestSdkConfigurationProvider extends SdkConfigurationProvider {
       }
     } catch (e, s) {
       _logger.warning('Failed delete SDK directory copy', e, s);
-      dispose(retry: false);
+      if (retry) {
+        dispose(retry: false);
+      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,9 @@ class TestSdkConfigurationProvider extends SdkConfigurationProvider {`
`80`	`80`	`}`
`81`	`81`	`} catch (e, s) {`
`82`	`82`	`_logger.warning('Failed delete SDK directory copy', e, s);`
`83`		`- dispose(retry: false);`
	`83`	`+ if (retry) {`
	`84`	`+ dispose(retry: false);`
	`85`	`+ }`
`84`	`86`	`}`
`85`	`87`	`}`
`86`	`88`	`}`