Skip to content

Commit 7ff5b0a

Browse files
committed
Update
1 parent 7cc3c8b commit 7ff5b0a

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed

frontend_server_client/CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
## 3.3.0-dev
1+
## 4.0.0-dev
2+
3+
- By default, start the frontend server from the AOT snapshot shipped in the
4+
Dart SDK.
5+
- Throw an `ArgumentError` when `FrontendServerClient.start` is called with the
6+
`frontendServerPath` argument omitted and the `debug` argument set to true.
7+
8+
## 3.3.0
29

310
- Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`.
411
- Support changes in the SDK layout for Dart 3.0.

frontend_server_client/lib/src/frontend_server_client.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ class FrontendServerClient {
4747
///
4848
/// When the [frontendServerPath] argument is provided, setting [debug] to
4949
/// true permits debuggers to attach to the frontend server. When the
50-
/// [frontendServerPath] argument is omitted, the value of the [debug]
51-
/// argument is ignored.
50+
/// [frontendServerPath] argument is omitted, setting [debug] to true will
51+
/// cause an [ArgumentError] to be thrown.
5252
static Future<FrontendServerClient> start(
5353
String entrypoint,
5454
String outputDillPath,
@@ -109,6 +109,10 @@ class FrontendServerClient {
109109
commonArguments,
110110
);
111111
} else if (File(_feServerAotSnapshotPath).existsSync()) {
112+
if (debug) {
113+
throw ArgumentError('The debug argument cannot be set to true when the '
114+
'frontendServerPath argument is omitted.');
115+
}
112116
feServer = await Process.start(
113117
_dartAotRuntimePath,
114118
<String>[_feServerAotSnapshotPath] + commonArguments,

frontend_server_client/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: frontend_server_client
2-
version: 3.3.0-dev
2+
version: 4.0.0-dev
33
description: >-
44
Client code to start and interact with the frontend_server compiler from the
55
Dart SDK.

frontend_server_common/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.2.2
2+
3+
- Start the frontend server from the AOT snapshot shipped in the Dart SDK.
4+
15
## 0.2.1
26

37
- Doe not pass `-debugger-module-names` flag to the frontend server.

test_common/lib/test_sdk_layout.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class TestSdkLayout {
9494
sdkLayout.sdkDirectory,
9595
'bin',
9696
'snapshots',
97-
'frontend_server.dart.snapshot',
97+
'frontend_server_aot.dart.snapshot',
9898
),
9999
dartdevcSnapshotPath: sdkLayout.dartdevcSnapshotPath,
100100
kernelWorkerSnapshotPath: p.join(

0 commit comments

Comments
 (0)