Skip to content

Commit 8033d67

Browse files
author
Anna Gringauze
authored
Reliably find unused port to start extension backend http service on (#1451)
We start extension backend http server with port 0, which creates flakes in flutter web tests. Find an unused port instead. Closes: #1450
1 parent bd399e1 commit 8033d67

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dwds/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
flutter tools and webdev.
1313

1414
- Fix chrome detection in iPhone emulation mode in chrome or edge browsers.
15+
- Reliably find unused port for extension backend http service.
1516

1617
## 11.4.0
1718

dwds/lib/src/servers/extension_backend.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import 'dart:async';
88
import 'dart:io';
99

1010
import 'package:async/async.dart';
11-
import 'package:http_multi_server/http_multi_server.dart';
1211
import 'package:logging/logging.dart';
1312
import 'package:shelf/shelf.dart';
1413

@@ -54,7 +53,7 @@ class ExtensionBackend {
5453
}
5554
return Response.notFound('');
5655
}).add(_socketHandler.handler);
57-
var server = await HttpMultiServer.bind(hostname, 0);
56+
var server = await startHttpServer(hostname);
5857
serveHttpRequests(server, cascade.handler, (e, s) {
5958
_logger.warning('Error serving requests', e);
6059
emitEvent(DwdsEvent.httpRequestException('ExtensionBackend', '$e:$s'));

0 commit comments

Comments
 (0)