Skip to content

Commit 8156106

Browse files
authored
[DWDS] Account for the optional parameters that will be added in package:vm_service_interface 2.0.0 (#2490)
This is needed to land the SDK CL that checks in package:vm_service_interface 2.0.0, because this is needed to make the g3-cbuild-try job pass.
1 parent 3deaa0c commit 8156106

File tree

2 files changed

+37
-5
lines changed

2 files changed

+37
-5
lines changed

dwds/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
- Spawn DDS in a separate process using `dart development-service` instead of launching from `package:dds`. - [#2466](https://github.com/dart-lang/webdev/pull/2466)
1212
- Update package `web_socket_channel: '>=2.2.0 <4.0.0'`.
1313
- Require Dart `^3.4`
14+
- Prepare to update `package:vm_service_interface` constraint to `2.0.0`.
1415

1516
## 24.0.0
1617

dwds/lib/src/services/chrome_proxy_service.dart

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
623623
Map<String, String>? scope,
624624
// TODO(798) - respect disableBreakpoints.
625625
bool? disableBreakpoints,
626+
627+
/// Note that `idZoneId` arguments will be ignored. This parameter is only
628+
/// here to make this method is a valid override of
629+
/// [VmServiceInterface.evaluate].
630+
String? idZoneId,
626631
}) =>
627632
wrapInErrorHandlerAsync(
628633
'evaluate',
@@ -716,6 +721,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
716721
Map<String, String>? scope,
717722
// TODO(798) - respect disableBreakpoints.
718723
bool? disableBreakpoints,
724+
725+
/// Note that `idZoneId` arguments will be ignored. This parameter is only
726+
/// here to make this method is a valid override of
727+
/// [VmServiceInterface.evaluateInFrame].
728+
String? idZoneId,
719729
}) =>
720730
wrapInErrorHandlerAsync(
721731
'evaluateInFrame',
@@ -805,6 +815,7 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
805815
int limit, {
806816
bool? includeImplementers,
807817
bool? includeSubclasses,
818+
String? idZoneId,
808819
}) {
809820
return _rpcNotSupportedFuture('getInstances');
810821
}
@@ -845,6 +856,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
845856
String objectId, {
846857
int? offset,
847858
int? count,
859+
860+
/// Note that `idZoneId` arguments will be ignored. This parameter is only
861+
/// here to make this method is a valid override of
862+
/// [VmServiceInterface.getObject].
863+
String? idZoneId,
848864
}) =>
849865
wrapInErrorHandlerAsync(
850866
'getObject',
@@ -946,7 +962,15 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
946962
///
947963
/// The returned stack will contain up to [limit] frames if provided.
948964
@override
949-
Future<Stack> getStack(String isolateId, {int? limit}) =>
965+
Future<Stack> getStack(
966+
String isolateId, {
967+
int? limit,
968+
969+
/// Note that `idZoneId` arguments will be ignored. This parameter is only
970+
/// here to make this method is a valid override of
971+
/// [VmServiceInterface.getStack].
972+
String? idZoneId,
973+
}) =>
950974
wrapInErrorHandlerAsync(
951975
'getStack',
952976
() => _getStack(isolateId, limit: limit),
@@ -1002,6 +1026,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
10021026
List argumentIds, {
10031027
// TODO(798) - respect disableBreakpoints.
10041028
bool? disableBreakpoints,
1029+
1030+
/// Note that `idZoneId` arguments will be ignored. This parameter is only
1031+
/// here to make this method is a valid override of
1032+
/// [VmServiceInterface.invoke].
1033+
String? idZoneId,
10051034
}) =>
10061035
wrapInErrorHandlerAsync(
10071036
'invoke',
@@ -1591,17 +1620,19 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
15911620
Future<InboundReferences> getInboundReferences(
15921621
String isolateId,
15931622
String targetId,
1594-
int limit,
1595-
) {
1623+
int limit, {
1624+
String? idZoneId,
1625+
}) {
15961626
return _rpcNotSupportedFuture('getInboundReferences');
15971627
}
15981628

15991629
@override
16001630
Future<RetainingPath> getRetainingPath(
16011631
String isolateId,
16021632
String targetId,
1603-
int limit,
1604-
) {
1633+
int limit, {
1634+
String? idZoneId,
1635+
}) {
16051636
return _rpcNotSupportedFuture('getRetainingPath');
16061637
}
16071638

0 commit comments

Comments
 (0)