Skip to content

Commit aa586d2

Browse files
authored
Fix DCM errors in chrome_proxy_service.dart (#2148)
1 parent b58edb7 commit aa586d2

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

dwds/lib/src/services/chrome_proxy_service.dart

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,7 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
580580
String targetId,
581581
String expression, {
582582
Map<String, String>? scope,
583+
// TODO(798) - respect disableBreakpoints.
583584
bool? disableBreakpoints,
584585
}) =>
585586
wrapInErrorHandlerAsync(
@@ -589,7 +590,6 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
589590
targetId,
590591
expression,
591592
scope: scope,
592-
disableBreakpoints: disableBreakpoints,
593593
),
594594
);
595595

@@ -598,7 +598,6 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
598598
String targetId,
599599
String expression, {
600600
Map<String, String>? scope,
601-
bool? disableBreakpoints,
602601
}) {
603602
// TODO(798) - respect disableBreakpoints.
604603
return captureElapsedTime(
@@ -637,6 +636,7 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
637636
int frameIndex,
638637
String expression, {
639638
Map<String, String>? scope,
639+
// TODO(798) - respect disableBreakpoints.
640640
bool? disableBreakpoints,
641641
}) =>
642642
wrapInErrorHandlerAsync(
@@ -646,7 +646,6 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
646646
frameIndex,
647647
expression,
648648
scope: scope,
649-
disableBreakpoints: disableBreakpoints,
650649
),
651650
);
652651

@@ -655,7 +654,6 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
655654
int frameIndex,
656655
String expression, {
657656
Map<String, String>? scope,
658-
bool? disableBreakpoints,
659657
}) {
660658
// TODO(798) - respect disableBreakpoints.
661659

@@ -908,6 +906,7 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
908906
String targetId,
909907
String selector,
910908
List argumentIds, {
909+
// TODO(798) - respect disableBreakpoints.
911910
bool? disableBreakpoints,
912911
}) =>
913912
wrapInErrorHandlerAsync(
@@ -917,20 +916,17 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
917916
targetId,
918917
selector,
919918
argumentIds,
920-
disableBreakpoints: disableBreakpoints,
921919
),
922920
);
923921

924922
Future<Response> _invoke(
925923
String isolateId,
926924
String targetId,
927925
String selector,
928-
List argumentIds, {
929-
bool? disableBreakpoints,
930-
}) async {
926+
List argumentIds,
927+
) async {
931928
await isInitialized;
932929
_checkIsolate('invoke', isolateId);
933-
// TODO(798) - respect disableBreakpoints.
934930
final remote = await inspector.invoke(targetId, selector, argumentIds);
935931
return _instanceRef(remote);
936932
}
@@ -1001,14 +997,13 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
1001997
}) =>
1002998
wrapInErrorHandlerAsync(
1003999
'lookupResolvedPackageUris',
1004-
() => _lookupResolvedPackageUris(isolateId, uris, local: local),
1000+
() => _lookupResolvedPackageUris(isolateId, uris),
10051001
);
10061002

10071003
Future<UriList> _lookupResolvedPackageUris(
10081004
String isolateId,
1009-
List<String> uris, {
1010-
bool? local,
1011-
}) async {
1005+
List<String> uris,
1006+
) async {
10121007
await isInitialized;
10131008
_checkIsolate('lookupResolvedPackageUris', isolateId);
10141009
return UriList(uris: uris.map(DartUri.toResolvedUri).toList());
@@ -1140,24 +1135,22 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
11401135
Future<Success> setIsolatePauseMode(
11411136
String isolateId, {
11421137
String? exceptionPauseMode,
1138+
// TODO(elliette): Is there a way to respect the shouldPauseOnExit parameter
1139+
// in Chrome?
11431140
bool? shouldPauseOnExit,
11441141
}) =>
11451142
wrapInErrorHandlerAsync(
11461143
'setIsolatePauseMode',
11471144
() => _setIsolatePauseMode(
11481145
isolateId,
11491146
exceptionPauseMode: exceptionPauseMode,
1150-
shouldPauseOnExit: shouldPauseOnExit,
11511147
),
11521148
);
11531149

11541150
Future<Success> _setIsolatePauseMode(
11551151
String isolateId, {
11561152
String? exceptionPauseMode,
1157-
bool? shouldPauseOnExit,
11581153
}) async {
1159-
// TODO(elliette): Is there a way to respect the shouldPauseOnExit parameter
1160-
// in Chrome?
11611154
await isInitialized;
11621155
_checkIsolate('setIsolatePauseMode', isolateId);
11631156
return (await debuggerFuture)

0 commit comments

Comments
 (0)