Skip to content

Commit b62a32b

Browse files
authored
Return cross extension debug response (#1267)
* Return cross extension debug response * update comment
1 parent eda644b commit b62a32b

File tree

5 files changed

+2432
-2438
lines changed

5 files changed

+2432
-2438
lines changed

dwds/debug_extension/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
## 1.19-dev
1+
## 1.20
2+
3+
- Return response when `dwds.startDebugging` is called.
4+
5+
6+
## 1.19
27

38
- Support cross-extension communication for use with Google specific extensions.
49

dwds/debug_extension/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: extension
22
publish_to: none
3-
version: 1.19.0-dev
3+
version: 1.20.0
44
author: Dart Team <[email protected]>
55
homepage: https://github.com/dart-lang/webdev
66
description: >-

dwds/debug_extension/web/background.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,9 @@ void main() {
133133
sendResponse(_tabIdToEncodedUri[request.tabId] ?? '');
134134
} else if (request.name == 'dwds.startDebugging') {
135135
startDebugging(null);
136+
// TODO(grouma) - Actually determine if debugging initiated
137+
// successfully.
138+
sendResponse(true);
136139
} else {
137140
sendResponse(
138141
ErrorResponse()..error = 'Unknown request name: ${request.name}');

0 commit comments

Comments
 (0)