Skip to content

Commit c164231

Browse files
authored
Small fix to the extension test (#1811)
1 parent 4bbb4d0 commit c164231

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

dwds/test/puppeteer/extension_test.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,15 +133,14 @@ void main() async {
133133
// Verify the extension opened the Dart docs in the same window:
134134
var devToolsTabTarget = await browser.waitForTarget(
135135
(target) => target.url.contains(devToolsUrlFragment));
136-
final devToolsPage = await devToolsTabTarget.page;
136+
var devToolsTab = await devToolsTabTarget.page;
137137
var devToolsWindowId = await _getWindowId(
138-
devToolsPage.url!,
138+
devToolsTab.url!,
139139
worker: worker,
140140
);
141141
var appWindowId = await _getWindowId(appUrl, worker: worker);
142142
expect(devToolsWindowId == appWindowId, isTrue);
143143
// Close the DevTools tab:
144-
var devToolsTab = await devToolsTabTarget.page;
145144
await devToolsTab.close();
146145
// Navigate to the extension settings page:
147146
final extensionOrigin = getExtensionOrigin(browser);
@@ -164,8 +163,10 @@ void main() async {
164163
// Verify the extension opened DevTools in a different window:
165164
devToolsTabTarget = await browser.waitForTarget(
166165
(target) => target.url.contains(devToolsUrlFragment));
166+
devToolsTab = await devToolsTabTarget.page;
167+
await devToolsTab.bringToFront();
167168
devToolsWindowId = await _getWindowId(
168-
devToolsPage.url!,
169+
devToolsTab.url!,
169170
worker: worker,
170171
);
171172
appWindowId = await _getWindowId(appUrl, worker: worker);
@@ -197,6 +198,7 @@ void main() async {
197198
await appTab.bringToFront();
198199
// Verify that the Dart DevTools tab closes:
199200
await devToolsTabTarget.onClose;
201+
await appTab.close();
200202
});
201203

202204
test('Closing the Dart app while debugging closes DevTools', () async {

0 commit comments

Comments
 (0)