Skip to content

Commit d6ec127

Browse files
author
Anna Gringauze
authored
Move test-only code from the SdkLayout (#1955)
* Validate only needed summaries in expression_compiler_service * Move test-only code out of the SDK layout * build
1 parent 35fa34b commit d6ec127

17 files changed

+405
-333
lines changed

dwds/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 17.0.1-dev
1+
## 18.0.0-dev
22

33
- Cleanup `getObject` code for lists and maps.
44
- Now works with offset `0` and `null` count.
@@ -9,6 +9,11 @@
99
- Update `package:dds` constraint to `^2.7.1`.
1010
- Fill `BoundField.name` for records.
1111
- Display records as a container of fields.
12+
- Remove test-only code from `sdk_configuration.dart`.
13+
14+
**Breaking changes**
15+
- Require `sdkConfigurationProvider` in `ExpressionCompilerService`
16+
constructor.
1217

1318
## 17.0.0
1419

dwds/lib/sdk_configuration.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
2+
// for details. All rights reserved. Use of this source code is governed by a
3+
// BSD-style license that can be found in the LICENSE file.
4+
5+
export 'src/utilities/sdk_configuration.dart'
6+
show
7+
SdkLayout,
8+
SdkConfiguration,
9+
SdkConfigurationProvider,
10+
DefaultSdkConfigurationProvider;

dwds/lib/src/injected/client.js

Lines changed: 68 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/lib/src/services/expression_compiler_service.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -236,17 +236,15 @@ class ExpressionCompilerService implements ExpressionCompiler {
236236
final List<String> experiments;
237237
final bool _verbose;
238238

239-
final SdkConfigurationProvider _sdkConfigurationProvider;
239+
final SdkConfigurationProvider sdkConfigurationProvider;
240240

241241
ExpressionCompilerService(
242242
this._address,
243243
this._port, {
244244
bool verbose = false,
245-
SdkConfigurationProvider sdkConfigurationProvider =
246-
const DefaultSdkConfigurationProvider(),
245+
required this.sdkConfigurationProvider,
247246
this.experiments = const [],
248-
}) : _verbose = verbose,
249-
_sdkConfigurationProvider = sdkConfigurationProvider;
247+
}) : _verbose = verbose;
250248

251249
@override
252250
Future<ExpressionCompilationResult> compileExpressionToJs(
@@ -271,7 +269,7 @@ class ExpressionCompilerService implements ExpressionCompiler {
271269
await _port,
272270
moduleFormat,
273271
soundNullSafety,
274-
await _sdkConfigurationProvider.configuration,
272+
await sdkConfigurationProvider.configuration,
275273
experiments,
276274
_verbose,
277275
);

0 commit comments

Comments
 (0)