File tree 3 files changed +39
-4
lines changed
3 files changed +39
-4
lines changed Original file line number Diff line number Diff line change @@ -179,8 +179,12 @@ class SymbolTable {
179
179
functionTypes.addAll ({
180
180
unresolvedFunctionType.id: unresolvedFunctionType,
181
181
});
182
- types..addAll (classes)..addAll (functionTypes);
183
- scopes..addAll (classes)..addAll (libraries);
182
+ types
183
+ ..addAll (classes)
184
+ ..addAll (functionTypes);
185
+ scopes
186
+ ..addAll (classes)
187
+ ..addAll (libraries);
184
188
}
185
189
186
190
FunctionSymbol getGlobalFunction (String localId) {
Original file line number Diff line number Diff line change @@ -95,7 +95,7 @@ class ChromeProxyService implements VmServiceInterface {
95
95
final ExpressionCompiler _compiler;
96
96
ExpressionEvaluator _expressionEvaluator;
97
97
98
- final bool _enableDebugSymbols;
98
+ bool _enableDebugSymbols;
99
99
100
100
bool terminatingIsolates = false ;
101
101
@@ -125,7 +125,8 @@ class ChromeProxyService implements VmServiceInterface {
125
125
_debuggerCompleter.complete (debugger);
126
126
127
127
if (_enableDebugSymbols) {
128
- throw UnimplementedError ('Debug symbols are not uset yet.' );
128
+ _logger.warning ('Ignoring --enable-debug-symbols (not implemented yet).' );
129
+ _enableDebugSymbols = false ;
129
130
}
130
131
}
131
132
Original file line number Diff line number Diff line change @@ -274,6 +274,36 @@ void main() {
274
274
}
275
275
});
276
276
277
+ group ('should not yet work with --enable-debug-symbols' , () {
278
+ test ('run webdev' , () async {
279
+ var openPort = await findUnusedPort ();
280
+ // running daemon command that starts dwds without keyboard input
281
+ var args = [
282
+ 'daemon' ,
283
+ 'web:$openPort ' ,
284
+ '--enable-expression-evaluation' ,
285
+ '--enable-debug-symbols' ,
286
+ '--verbose' ,
287
+ ];
288
+ var process = await runWebDev (args, workingDirectory: exampleDirectory);
289
+ try {
290
+ await expectLater (process.stdout,
291
+ emitsThrough (contains ('Ignoring --enable-debug-symbols' )));
292
+
293
+ // Wait for debug service Uri
294
+ String wsUri;
295
+ await expectLater (process.stdout, emitsThrough ((String m) {
296
+ wsUri = getDebugServiceUri (m);
297
+ return wsUri != null ;
298
+ }));
299
+ expect (wsUri, isNotNull);
300
+ } finally {
301
+ await exitWebdev (process);
302
+ await process.shouldExit ();
303
+ }
304
+ });
305
+ });
306
+
277
307
group ('should work with ' , () {
278
308
for (var soundNullSafety in [false , true ]) {
279
309
var nullSafetyOption = soundNullSafety ? 'sound' : 'unsound' ;
You can’t perform that action at this time.
0 commit comments