Skip to content

Prepare for temporary names update in DDC #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annagrin opened this issue Mar 18, 2023 · 0 comments · Fixed by #2042
Closed

Prepare for temporary names update in DDC #2041

annagrin opened this issue Mar 18, 2023 · 0 comments · Fixed by #2042
Assignees
@annagrin
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 3 beta 3

Comments

@annagrin
Copy link
Contributor

To better support debugging of patterns, we need to change a naming scheme for temporary variables in DDC.

Make sure DWDS knows how to recognize temporary names and not display them. Support both versions until dart 3.0 is in stable.

See changes in temp names coming from: https://dart-review.git.corp.google.com/c/sdk/+/288829
@annagrin annagrin self-assigned this Mar 18, 2023
@annagrin annagrin added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Mar 18, 2023
@annagrin annagrin added this to the Dart 3 beta 3 milestone Mar 18, 2023
@annagrin annagrin mentioned this issue Mar 18, 2023
Merged
@annagrin annagrin mentioned this issue Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annagrin annagrin

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 3 beta 3
Development

Successfully merging a pull request may close this issue.

Prepare for variable names changes due to patterns support in DDC annagrin/webdev
1 participant
@annagrin