Skip to content

Replace boolean fields in ClassMetadata by an instance kind #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annagrin opened this issue Apr 25, 2023 · 1 comment
Closed

Replace boolean fields in ClassMetadata by an instance kind #2101

annagrin opened this issue Apr 25, 2023 · 1 comment

Comments

@annagrin
Copy link
Contributor

Use InstanceKind from vm service protocol instead of boolean fields in class metadata - it looks like we only need them internally in class.dart.

webdev/dwds/lib/src/debugging/metadata/class.dart

Line 228 in 12f2285

/// TODO(annagrin): convert fields and getters below to kinds.

@annagrin annagrin mentioned this issue Apr 25, 2023
Closed
@annagrin
Copy link
Contributor Author

Implemented in #2103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify class metadata annagrin/webdev
1 participant
@annagrin