Skip to content

Commit 13990d8

Browse files
committed
merge bitcoin-core/gui#673: Use fallback value for Version and User Agent during peer connection
1 parent 320f0e6 commit 13990d8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/qt/rpcconsole.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,8 +1304,12 @@ void RPCConsole::updateDetailWidget()
13041304
ui->peerPingTime->setText(GUIUtil::formatPingTime(stats->nodeStats.m_last_ping_time));
13051305
ui->peerMinPing->setText(GUIUtil::formatPingTime(stats->nodeStats.m_min_ping_time));
13061306
ui->timeoffset->setText(GUIUtil::formatTimeOffset(stats->nodeStats.nTimeOffset));
1307-
ui->peerVersion->setText(QString::number(stats->nodeStats.nVersion));
1308-
ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer));
1307+
if (stats->nodeStats.nVersion) {
1308+
ui->peerVersion->setText(QString::number(stats->nodeStats.nVersion));
1309+
}
1310+
if (!stats->nodeStats.cleanSubVer.empty()) {
1311+
ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer));
1312+
}
13091313
ui->peerConnectionType->setText(GUIUtil::ConnectionTypeToQString(stats->nodeStats.m_conn_type, /* prepend_direction */ true));
13101314
ui->peerTransportType->setText(QString::fromStdString(TransportTypeAsString(stats->nodeStats.m_transport_type)));
13111315
if (stats->nodeStats.m_transport_type == TransportProtocolType::V2) {

0 commit comments

Comments
 (0)