Skip to content

Commit 3450fa5

Browse files
MarcoFalkePastaPastaPasta
authored andcommitted
Merge bitcoin#21846: fuzz: Add -fsanitize=integer suppression needed for RPC fuzzer (generateblock)
575792e fuzz: Add -fsanitize=integer suppression needed for RPC fuzzer (practicalswift) Pull request description: Add `-fsanitize=integer` suppression needed for RPC fuzzer (`generateblock`). Context: https://github.com/bitcoin-core/qa-assets/pull/59/checks?check_run_id=2494624259 ``` miner.cpp:130:21: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value 244763573890 (64-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 4245405314 (32-bit, unsigned) #0 0x56143974eaf3 in BlockAssembler::CreateNewBlock(CScript const&) miner.cpp:130:21 #1 0x56143993690d in generateblock()::$_4::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/mining.cpp:370:127 ``` ACKs for top commit: practicalswift: > review ACK [575792e](bitcoin@575792e), but this function shouldn't be called by the rpc fuzzer, at least not without sanitizing num_blocks MarcoFalke: review ACK 575792e Tree-SHA512: c2133d1064bf17df0e7749ef4a0f7664b5c8082040491a1035d39f0c6e5d96997b347ef2354411e285c7f1f973e34515f1c3c88eb3de60fab64ca4d2adf6dd74
1 parent 41eb1b2 commit 3450fa5

File tree

1 file changed

+1
-0
lines changed
  • test/sanitizer_suppressions

1 file changed

+1
-0
lines changed

test/sanitizer_suppressions/ubsan

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ implicit-signed-integer-truncation:chain.h
8888
implicit-signed-integer-truncation:crypto/
8989
implicit-signed-integer-truncation:cuckoocache.h
9090
implicit-signed-integer-truncation:leveldb/
91+
implicit-signed-integer-truncation:miner.cpp
9192
implicit-signed-integer-truncation:net.cpp
9293
implicit-signed-integer-truncation:net_processing.cpp
9394
implicit-signed-integer-truncation:streams.h

0 commit comments

Comments
 (0)