Skip to content

Commit a656d2f

Browse files
committed
feat: more logging
1 parent cedd3d5 commit a656d2f

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

test/functional/feature_llmq_simplepose.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ def force_old_mn_proto(self, mn):
9191
return False, True
9292

9393
def test_no_banning(self, expected_connections=None):
94-
for _ in range(3):
94+
for i in range(3):
95+
self.log.info(f"Testing no PoSe banning in normal conditions {i + 1}/3")
9596
self.mine_quorum(expected_connections=expected_connections)
9697
for mn in self.mninfo:
9798
assert not self.check_punished(mn) and not self.check_banned(mn)
@@ -162,7 +163,8 @@ def test_banning(self, invalidate_proc, expected_connections=None):
162163
mninfos_online = self.mninfo.copy()
163164
mninfos_valid = self.mninfo.copy()
164165
expected_contributors = len(mninfos_online)
165-
for _ in range(2):
166+
for i in range(2):
167+
self.log.info(f"Testing PoSe banning due to {invalidate_proc.__name__} {i + 1}/2")
166168
mn = mninfos_valid.pop()
167169
went_offline, instant_ban = invalidate_proc(mn)
168170
expected_complaints = expected_contributors - 1
@@ -174,13 +176,15 @@ def test_banning(self, invalidate_proc, expected_connections=None):
174176
# so nodes are PoSe-banned in the same DKG they misbehave without being PoSe-punished first.
175177
if instant_ban:
176178
assert expected_connections is not None
179+
self.log.info("Expecting instant PoSe banning")
177180
self.reset_probe_timeouts()
178181
self.mine_quorum(expected_connections=expected_connections, expected_members=expected_contributors, expected_contributions=expected_contributors, expected_complaints=expected_complaints, expected_commitments=expected_contributors, mninfos_online=mninfos_online, mninfos_valid=mninfos_valid)
179182
else:
180183
# It's ok to miss probes/quorum connections up to 5 times.
181184
# 6th time is when it should be banned for sure.
182185
assert expected_connections is None
183-
for _ in range(6):
186+
for j in range(6):
187+
self.log.info(f"Accumulating PoSe penalty {j + 1}/6")
184188
self.reset_probe_timeouts()
185189
self.mine_quorum_less_checks(expected_contributors - 1, mninfos_online)
186190

@@ -191,7 +195,7 @@ def test_banning(self, invalidate_proc, expected_connections=None):
191195
expected_contributors -= 1
192196

193197
def repair_masternodes(self, restart):
194-
# Repair all nodes
198+
self.log.info("Repairing all banned and punished masternodes")
195199
for mn in self.mninfo:
196200
if self.check_banned(mn) or self.check_punished(mn):
197201
addr = self.nodes[0].getnewaddress()

0 commit comments

Comments
 (0)