Skip to content

vecdot does not conjugate the first argument #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhvk opened this issue Nov 19, 2024 · 0 comments · Fixed by #98
Closed

vecdot does not conjugate the first argument #97

mhvk opened this issue Nov 19, 2024 · 0 comments · Fixed by #98

Comments

@mhvk
Copy link

mhvk commented Nov 19, 2024

The implementation for vecdot should conjugate its first argument for complex numbers, but unfortunately the present implementation does not:

array-api-strict/array_api_strict/_linear_algebra_functions.py

Line 89 in d086c61

res = x1_[..., None, :] @ x2_[..., None]

(array_api_compat has the same issue: data-apis/array-api-compat#200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conjugate the first argument in vecdot asmeurer/array-api-strict
1 participant
@mhvk