Skip to content

No default_complex when xp.asarray is not present #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtsokol opened this issue Nov 10, 2023 · 1 comment · Fixed by #209
Closed

No default_complex when xp.asarray is not present #199

mtsokol opened this issue Nov 10, 2023 · 1 comment · Fixed by #209
Labels
bug Something isn't working low priority Low priority issue

Comments

@mtsokol
Copy link
Contributor

mtsokol commented Nov 10, 2023 •
edited
Loading

Hi!
I noticed that there isn't a default complex dtype when xp.asarray is not present if branch. Is it on purpose, or could default_complex be added there? (it causes a setup failure when running tests for a lib without xp.asarray)

array-api-tests/array_api_tests/dtype_helpers.py

Line 237 in b5ed713

default_float = xp.float32

@honno honno added the bug Something isn't working label Nov 10, 2023
@honno
Copy link
Member

honno commented Nov 10, 2023

Nice catch, yeah this would be a problem. Although generally if a library doesn't have xp.asarray not much is going to get tested anyway 😅

@honno honno added the low priority Low priority issue label Nov 10, 2023
@mtsokol mtsokol mentioned this issue Nov 16, 2023
Merged
@honno honno linked a pull request Nov 16, 2023 that will close this issue
Add default_complex when xp.asarray isn't present #209
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low priority Low priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default_complex when xp.asarray isn't present mtsokol/array-api-tests
2 participants
@honno @mtsokol