From 9503db052bde4344e1cdb939348a37202821d25c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Sok=C3=B3=C5=82?= Date: Thu, 16 Nov 2023 11:47:45 +0100 Subject: [PATCH 1/2] Add default_complex when xp.asarray isn't present --- array_api_tests/dtype_helpers.py | 1 + 1 file changed, 1 insertion(+) diff --git a/array_api_tests/dtype_helpers.py b/array_api_tests/dtype_helpers.py index 6e37724c..38c8d843 100644 --- a/array_api_tests/dtype_helpers.py +++ b/array_api_tests/dtype_helpers.py @@ -235,6 +235,7 @@ class MinMax(NamedTuple): if not hasattr(xp, "asarray"): default_int = xp.int32 default_float = xp.float32 + default_complex = xp.complex64 if api_version > "2021.12" else None warn( "array module does not have attribute asarray. " "default int is assumed int32, default float is assumed float32" From ffeb7cb666b1cfdd6268683154fd8737855653f2 Mon Sep 17 00:00:00 2001 From: Matthew Barber Date: Thu, 16 Nov 2023 11:53:08 +0000 Subject: [PATCH 2/2] Try except method for assigning `default_complex` --- array_api_tests/dtype_helpers.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/array_api_tests/dtype_helpers.py b/array_api_tests/dtype_helpers.py index 38c8d843..9c2f3bfe 100644 --- a/array_api_tests/dtype_helpers.py +++ b/array_api_tests/dtype_helpers.py @@ -235,7 +235,12 @@ class MinMax(NamedTuple): if not hasattr(xp, "asarray"): default_int = xp.int32 default_float = xp.float32 - default_complex = xp.complex64 if api_version > "2021.12" else None + # TODO: when api_version > '2021.12', just assign to xp.complex64, + # otherwise default to None. Need array-api spec to be bumped first (#187). + try: + default_complex = xp.complex64 + except AttributeError: + default_complex = None warn( "array module does not have attribute asarray. " "default int is assumed int32, default float is assumed float32"