Skip to content

Test values of buffers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
honno opened this issue Jul 29, 2022 · 1 comment
Closed

Test values of buffers #10

honno opened this issue Jul 29, 2022 · 1 comment

Comments

@honno
Copy link
Member

honno commented Jul 29, 2022

Mentioned in data-apis/dataframe-api#75 (comment) that we could test the values of buffers. Not sure how hard it'll be for all the types of examples we generate, so I'll at least give it a go to scope it out. My initial impression is our round-trip testing would end up covering the vast majority of problems anywho.

@honno
Copy link
Member Author

honno commented Sep 15, 2022

My initial impression is our round-trip testing would end up covering the vast majority of problems anywho.

I think this is true. The round-trip tests cover testing the actual values of buffers, implicitly but extensively. Testing the values of buffers could be useful when trying to pinpoint issues, but the effort doesn't seem worth it.

@honno honno closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant