Skip to content

Fold in existing tests? #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
honno opened this issue Jun 21, 2022 · 1 comment
Closed

Fold in existing tests? #3

honno opened this issue Jun 21, 2022 · 1 comment

Comments

@honno
Copy link
Member

honno commented Jun 21, 2022

Efforts have already been made to test the df interchange protocol

Do we fold them in to this test suite?

  • With single-method tests, it depends how Test API methods (unrelated to memory) #2 goes. We see in array-api-tests that Hypothesis-powered tests per method end up covering a lot of manual testing anywho, in a much more maintainable/generalised way that also covers test cases we never think of.
  • With tests related to interesting interactions between methods, these won't be covered by Test API methods (unrelated to memory) #2 per-say:
    • A "complete" test per method covers basic interactions, e.g. you don't need to test whether you can get a column name and then access those columns, if you correctly test each step separately.
    • There are possibly interactions which aren't like that... a TODO is to identify what they are.

So a TODO for me is to properly review each of the listed test suites to see where inspiration can be taken from. Probably if #1 and/or #2 doesn't end up being that worth, just copying tests to have the coverage is nice, even if the test cases in dataframe-interchange-tests don't have clearly distinct test cases like I think array-api-tests does.

@honno
Copy link
Member Author

honno commented Sep 15, 2022

Do we fold them in to this test suite?

So no test cases have been lifted as-is, but I think we've captured all the interesting things out there now in the test suite, so closing.

@honno honno closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant