Skip to content

Extend end to end methods for applying checks#1064

Merged
mwojtyczka merged 6 commits into
mainfrom
extend_apply_checks_and_save_in_tables
Mar 17, 2026
Merged

Extend end to end methods for applying checks#1064
mwojtyczka merged 6 commits into
mainfrom
extend_apply_checks_and_save_in_tables

Conversation

@mwojtyczka

Copy link
Copy Markdown
Contributor

Changes

  • Extended end to end methods (apply_checks_and_save_in_table and apply_checks_by_metadata_and_save_in_table) to provide option for loading checks from a storage location, in addition to the existing option of using preloaded checks
  • Minor updates to best practices

[BREAKING CHANGE]

  • Parameter order in apply_checks_and_save_in_table and apply_checks_by_metadata_and_save_in_table methods is changed

Linked issues

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

@github-actions

Copy link
Copy Markdown
Contributor

All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@mwojtyczka mwojtyczka requested review from alexott and ghanse and removed request for grusin-db March 10, 2026 19:47
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

✅ 631/631 passed, 41 skipped, 4h1m13s total

Running from acceptance #4145

@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (54b9626) to head (91d8cd0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   92.02%   91.91%   -0.12%     
==========================================
  Files          98       98              
  Lines        9093     9104      +11     
==========================================
  Hits         8368     8368              
- Misses        725      736      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vb-dbrks vb-dbrks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mwojtyczka mwojtyczka merged commit 280ccd2 into main Mar 17, 2026
21 of 22 checks passed
@mwojtyczka mwojtyczka deleted the extend_apply_checks_and_save_in_tables branch March 17, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-approval Reviewed, and awaiting maintainer approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants