Extend end to end methods for applying checks#1064
Merged
Conversation
… and apply_checks_by_metadata_and_save_in_table engine methods
Contributor
|
All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Contributor
|
✅ 631/631 passed, 41 skipped, 4h1m13s total Running from acceptance #4145 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
- Coverage 92.02% 91.91% -0.12%
==========================================
Files 98 98
Lines 9093 9104 +11
==========================================
Hits 8368 8368
- Misses 725 736 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
apply_checks_and_save_in_tableandapply_checks_by_metadata_and_save_in_table) to provide option for loading checks from a storage location, in addition to the existing option of using preloaded checks[BREAKING CHANGE]
apply_checks_and_save_in_tableandapply_checks_by_metadata_and_save_in_tablemethods is changedLinked issues
Tests