docs: rename user to client_id in LakebaseChecksStorageConfig#1201
Merged
Conversation
Update the argument description and code examples to reflect the rename. The previous description incorrectly mentioned the "user@domain.com" format which no longer applies. - Renamed `user` to `client_id` in save/load examples - Updated bullet description in supported storage backends section
|
|
ghanse
self-requested a review
May 27, 2026 13:22
ghanse
approved these changes
May 27, 2026
ghanse
left a comment
ghanse
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution. This LGTM.
ghanse
added
the
Approved to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update the argument description and code examples in the Loading and Storing Quality Checks docs page to reflect the actual argument name in
LakebaseChecksStorageConfig, which usesclient_id: str | None = None, notuser. The previous docs referred touserand incorrectly described it as accepting auser@domain.comformat.usertoclient_idin save/load examplesTests
Documentation and Demos