Skip to content

Declare readme in the project#547

Merged
mwojtyczka merged 1 commit into
mainfrom
include_readme
Aug 25, 2025
Merged

Declare readme in the project#547
mwojtyczka merged 1 commit into
mainfrom
include_readme

Conversation

@mwojtyczka

@mwojtyczka mwojtyczka commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Including readme in the distribution to have it display correctly in PyPi. It is currently showing: The author of this package has not provided a project description

We used to generate readme dynamically, but it was removed 2 releases ago. We haven't change the readme declaration after this change.

Tests

  • manually tested - hatch build and checking the package info includes description
  • added unit tests
  • added integration tests
  • added end-to-end tests

@github-actions

github-actions Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

✅ 295/295 passed, 5 flaky, 1 skipped, 2h49m48s total

Flaky tests:

  • 🤪 test_fresh_user_config_installation (1m4.097s)
  • 🤪 test_is_data_fresh_cur (1.245s)
  • 🤪 test_e2e_workflow (13m36.253s)
  • 🤪 test_e2e_workflow_serverless (7m58.627s)
  • 🤪 test_e2e_workflow (7m53.6s)

Running from acceptance #2016

@mwojtyczka mwojtyczka merged commit f2d5cb7 into main Aug 25, 2025
13 checks passed
@mwojtyczka mwojtyczka deleted the include_readme branch August 25, 2025 14:08
mwojtyczka added a commit that referenced this pull request Sep 5, 2025
* Added performance benchmarks ([#548](#548)). Performance tests are run to ensure performance does not degrade by more than 25% by any change. Benchmark results are published in the documentation in the reference section. The benchmark covers all check functions, running all funcitons at once and applying the same funcitons at once for multiple columns using foreach column. A new performance GitHub workflow has been introduced to automate performance benchmarking, generating a new benchmark baseline, updating the existing baseline, and running performance tests to compare with the baseline.
* Declare readme in the project ([#547](#547)). The project configuration has been updated to include README file in the released package so that it is visible in PyPi.
* Fixed deserializing to DataFrame to assign columns properly ([#559](#559)). The `deserialize_checks_to_dataframe` function has been enhanced to correctly handle columns for `sql_expression` by removing the unnecessary check for `DQDatasetRule` instance and directly verifying if `dq_rule_check.columns` is not `None`.
* Fixed lsql dependency ([#564](#564)). The lsql dependency has been updated to address a sqlglot dependency issue that arises when imported in artifacts repositories.
@mwojtyczka mwojtyczka mentioned this pull request Sep 5, 2025
mwojtyczka added a commit that referenced this pull request Sep 5, 2025
* Added performance benchmarks
([#548](#548)). Performance
tests are run to ensure performance does not degrade by more than 25% by
any change. Benchmark results are published in the documentation in the
reference section. The benchmark covers all check functions, running all
funcitons at once and applying the same funcitons at once for multiple
columns using foreach column. A new performance GitHub workflow has been
introduced to automate performance benchmarking, generating a new
benchmark baseline, updating the existing baseline, and running
performance tests to compare with the baseline.
* Declare readme in the project
([#547](#547)). The project
configuration has been updated to include README file in the released
package so that it is visible in PyPi.
* Fixed deserializing to DataFrame to assign columns properly
([#559](#559)). The
`deserialize_checks_to_dataframe` function has been enhanced to
correctly handle columns for `sql_expression` by removing the
unnecessary check for `DQDatasetRule` instance and directly verifying if
`dq_rule_check.columns` is not `None`.
* Fixed lsql dependency
([#564](#564)). The lsql
dependency has been updated to address a sqlglot dependency issue that
arises when imported in artifacts repositories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants