Adding Lakebase checks storage backend#550
Conversation
|
All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Lakebase as a new storage backend for quality checks, allowing users to store and retrieve checks from Lakebase tables instead of only Delta tables or files.
- Introduces
LakebaseChecksStorageConfigconfiguration class with instance name and database location parameters - Implements
LakebaseChecksStorageHandlerwith PostgreSQL-based operations for loading and saving checks - Updates documentation and factory methods to include the new Lakebase backend option
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/databricks/labs/dqx/engine.py | Updates documentation to include Lakebase storage option |
| src/databricks/labs/dqx/config.py | Adds LakebaseChecksStorageConfig class with validation |
| src/databricks/labs/dqx/checks_storage.py | Implements LakebaseChecksStorageHandler with PostgreSQL connection pooling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Thanks for the PR!
Please also updated docs and add tests.
Please sign commits: https://databrickslabs.github.io/dqx/docs/dev/contributing/
e7b8ac3 to
9bb5e48
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9bb5e48 to
b333413
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ickslabs/dqx into feature_503_store_retrieve_checks
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Changes
Adding Lakebase checks storage backend.
Linked issues
Resolves #444
Tests