Fix lsql dependency#564
Merged
Merged
Conversation
## Changes <!-- Summary of your changes that are easy to understand. Add screenshots when necessary --> ### Linked issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Resolves #.. ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [ ] manually tested - [ ] added unit tests - [ ] added integration tests - [ ] added end-to-end tests - [ ] added performance tests
mwojtyczka
requested review from
nehamilak-db
and removed request for
a team
mwojtyczka
requested review from
Copilot and
ghanse
and removed request for
nehamilak-db
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the databricks-labs-lsql dependency version constraint to resolve sqlglot dependency conflicts when imported in artifacts repositories.
- Updated lsql dependency upper bound from
<0.15to<=0.16
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
✅ 295/295 passed, 3 flaky, 1 skipped, 2h35m40s total Flaky tests:
Running from acceptance #2212 |
mwojtyczka
added a commit
that referenced
this pull request
Sep 5, 2025
* Added performance benchmarks ([#548](#548)). Performance tests are run to ensure performance does not degrade by more than 25% by any change. Benchmark results are published in the documentation in the reference section. The benchmark covers all check functions, running all funcitons at once and applying the same funcitons at once for multiple columns using foreach column. A new performance GitHub workflow has been introduced to automate performance benchmarking, generating a new benchmark baseline, updating the existing baseline, and running performance tests to compare with the baseline. * Declare readme in the project ([#547](#547)). The project configuration has been updated to include README file in the released package so that it is visible in PyPi. * Fixed deserializing to DataFrame to assign columns properly ([#559](#559)). The `deserialize_checks_to_dataframe` function has been enhanced to correctly handle columns for `sql_expression` by removing the unnecessary check for `DQDatasetRule` instance and directly verifying if `dq_rule_check.columns` is not `None`. * Fixed lsql dependency ([#564](#564)). The lsql dependency has been updated to address a sqlglot dependency issue that arises when imported in artifacts repositories.
Merged
mwojtyczka
added a commit
that referenced
this pull request
Sep 5, 2025
* Added performance benchmarks ([#548](#548)). Performance tests are run to ensure performance does not degrade by more than 25% by any change. Benchmark results are published in the documentation in the reference section. The benchmark covers all check functions, running all funcitons at once and applying the same funcitons at once for multiple columns using foreach column. A new performance GitHub workflow has been introduced to automate performance benchmarking, generating a new benchmark baseline, updating the existing baseline, and running performance tests to compare with the baseline. * Declare readme in the project ([#547](#547)). The project configuration has been updated to include README file in the released package so that it is visible in PyPi. * Fixed deserializing to DataFrame to assign columns properly ([#559](#559)). The `deserialize_checks_to_dataframe` function has been enhanced to correctly handle columns for `sql_expression` by removing the unnecessary check for `DQDatasetRule` instance and directly verifying if `dq_rule_check.columns` is not `None`. * Fixed lsql dependency ([#564](#564)). The lsql dependency has been updated to address a sqlglot dependency issue that arises when imported in artifacts repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated lsql dependency to avoid sqlglot dependency issue when imported in artifacts repositories.
Tests
Changes
Linked issues
Resolves #..
Tests