Allow installation in a custom folder#575
Merged
Merged
Conversation
Contributor
|
✅ 336/336 passed, 2 flaky, 1 skipped, 3h9m2s total Flaky tests:
Running from acceptance #2416 |
mwojtyczka
reviewed
Sep 18, 2025
enable e2e tests on nightly
mwojtyczka
reviewed
Sep 18, 2025
mwojtyczka
reviewed
Sep 18, 2025
mwojtyczka
reviewed
Sep 18, 2025
mwojtyczka
approved these changes
Sep 19, 2025
mwojtyczka
left a comment
mwojtyczka
left a comment
Contributor
There was a problem hiding this comment.
LGTM - will merge after some manual testing
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a new installation prompt which asks users to provide a workspace path when installing DQX as a tool.
I've also refactored the engine to use
WorkspaceClient().get_workspace_id()instead ofWorkspaceClient().current_user.me()to support running checks on group-assigned clusters.Linked issues
Resolves #538, Resolves #545
Tests