Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit c724ffb

Browse files
author
Sergey Vasilyev
committed
Fix the aftermath of refactoring: cease instantiating abstract classes
1 parent 0b416df commit c724ffb

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

tests/test_format.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from data_diff.diff_tables import DiffResultWrapper, InfoTree, SegmentInfo, TableSegment
33
from data_diff.format import jsonify
44
from data_diff.abcs.database_types import Integer
5-
from data_diff.databases.base import Database
5+
from tests.test_query import MockDatabase
66

77

88
class TestFormat(unittest.TestCase):
@@ -13,8 +13,8 @@ def test_jsonify_diff(self):
1313
info_tree=InfoTree(
1414
info=SegmentInfo(
1515
tables=[
16-
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=Database()),
17-
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=Database()),
16+
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=MockDatabase()),
17+
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=MockDatabase()),
1818
],
1919
diff_schema=(
2020
("is_exclusive_a", bool),
@@ -100,8 +100,8 @@ def test_jsonify_no_stats(self):
100100
info_tree=InfoTree(
101101
info=SegmentInfo(
102102
tables=[
103-
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=Database()),
104-
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=Database()),
103+
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=MockDatabase()),
104+
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=MockDatabase()),
105105
],
106106
diff_schema=(
107107
("is_exclusive_a", bool),
@@ -177,8 +177,8 @@ def test_jsonify_diff_no_difeference(self):
177177
info_tree=InfoTree(
178178
info=SegmentInfo(
179179
tables=[
180-
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=Database()),
181-
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=Database()),
180+
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id",), database=MockDatabase()),
181+
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id",), database=MockDatabase()),
182182
],
183183
diff_schema=(
184184
("is_exclusive_a", bool),
@@ -251,8 +251,8 @@ def test_jsonify_column_suffix_fix(self):
251251
info_tree=InfoTree(
252252
info=SegmentInfo(
253253
tables=[
254-
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id_a",), database=Database()),
255-
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id_a",), database=Database()),
254+
TableSegment(table_path=("db", "schema", "table1"), key_columns=("id_a",), database=MockDatabase()),
255+
TableSegment(table_path=("db", "schema", "table2"), key_columns=("id_a",), database=MockDatabase()),
256256
],
257257
diff_schema=(
258258
("is_exclusive_a", bool),

tests/test_query.py

+2
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ def load_mixins(self):
7373

7474

7575
class MockDatabase(Database):
76+
CONNECT_URI_HELP = "mock://"
77+
CONNECT_URI_PARAMS = []
7678
dialect = MockDialect()
7779

7880
_query = NotImplemented

0 commit comments

Comments
 (0)