Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

PG connection URL has special characters in password #811

Closed
idling11 opened this issue Dec 26, 2023 · 2 comments · Fixed by #812
Closed

PG connection URL has special characters in password #811

idling11 opened this issue Dec 26, 2023 · 2 comments · Fixed by #812
Assignees
@sungchun12
Labels
bug Something isn't working triage

Comments

@idling11
Copy link
Contributor

Describe the bug
When connect to PG, if my password has special characters, may be like '@'. The code goes to dns parser will fail to extract the right password.
@idling11 idling11 added the bug Something isn't working label Dec 26, 2023
@idling11
Copy link
Contributor Author

My advice is： when user construct the url, he can use urllib.parser.quote to convert the special characters once. Make sure dns parser can extract right connection params. Then we use urllib.parser.unquote to convert the characters back to the connection dict.

@idling11
Copy link
Contributor Author

I got a pr for this issue. And fix a mysql reconnection bug by the way. #812

@sungchun12 sungchun12 self-assigned this Dec 26, 2023
@sungchun12 sungchun12 mentioned this issue Dec 26, 2023
Merged
@sushi30 sushi30 mentioned this issue Sep 18, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sungchun12 sungchun12

Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[to#811]Fix special characters in PG url and Mysql connection reconnect idling11/data-diff
2 participants
@idling11 @sungchun12