Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Support dbt Snowflake connection using key file itself rather than just path to key file #837

Closed
will-warner opened this issue Jan 3, 2024 · 2 comments
Labels
enhancement New feature or request stale Issues/PRs that have gone stale triage

Comments

@will-warner
Copy link

Is your feature request related to a problem? Please describe.
#792 enabled a Snowflake to connect using the key itself in addition to the previously allowed key path method.

dbt also supports connecting to Snowflake using the key itself as of 1.5, by providing private_key in your profile, ref.

The data-diff's dbt parser however has not been updated to parse this key from the dbt profile, meaning that you can only to connect to Snowflake via dbt using the key path method:

if credentials.get("private_key_path") is not None:
if credentials.get("password") is not None:
raise DataDiffDbtSnowflakeSetConnectionError("Cannot use password and key at the same time")
conn_info["key"] = credentials.get("private_key_path")
conn_info["private_key_passphrase"] = credentials.get("private_key_passphrase")

Describe the solution you'd like
Allow either the private_key_path or private_key to be parsed from the dbt profile.

Describe alternatives you've considered
NA

Additional context
Add any other context or screenshots about the feature request here.

@will-warner will-warner added the enhancement New feature or request label Jan 3, 2024
@github-actions github-actions bot added the triage label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Mar 4, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request stale Issues/PRs that have gone stale triage
Projects
None yet
Development

No branches or pull requests

1 participant