Release lock earlier

jorgebay · jorgebay · commit 60ced89a46a9 · 2020-04-24T10:48:03.000+02:00
diff --git a/graphql/updater.go b/graphql/updater.go
@@ -24,8 +24,8 @@ type SchemaUpdater struct {
 func (su *SchemaUpdater) Schema(keyspace string) *graphql.Schema {
 	// This should be pretty fast, but an atomic pointer swap wouldn't require a lock here
 	su.mutex.Lock()
-	defer su.mutex.Unlock()
 	schemas := *su.schemas
+	su.mutex.Unlock()
 	return schemas[keyspace]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,8 @@ type SchemaUpdater struct {`
`24`	`24`	`func (su SchemaUpdater) Schema(keyspace string) graphql.Schema {`
`25`	`25`	`// This should be pretty fast, but an atomic pointer swap wouldn't require a lock here`
`26`	`26`	`su.mutex.Lock()`
`27`		`- defer su.mutex.Unlock()`
`28`	`27`	`schemas := *su.schemas`
	`28`	`+ su.mutex.Unlock()`
`29`	`29`	`return schemas[keyspace]`
`30`	`30`	`}`
`31`	`31`