updated deps and examples error reporting

Author: daveshanley

functions/openapi/oas_schema.go

@@ -145,20 +145,29 @@ func (os OASSchema) RunRule(nodes []*yaml.Node, context model.RuleFunctionContex
 			}
 
 			schemaErr := validationErrors[i].SchemaValidationErrors[y]
-			var reason = schemaErr.Reason
-			// if reason is empty or generic, extract leaf error messages (issue #766)
-			if reason == "validation failed" || reason == "" {
-				if schemaErr.OriginalError != nil {
-					leafErrors := extractLeafValidationErrors(schemaErr.OriginalError)
-					if len(leafErrors) > 0 {
-						reason = strings.Join(leafErrors, "; ")
+			var reason string
+
+			// Always prefer leaf error extraction from OriginalError when available (issue #766)
+			if schemaErr.OriginalError != nil {
+				leafErrors := extractLeafValidationErrors(schemaErr.OriginalError)
+				if len(leafErrors) > 0 {
+					// Limit to last 3 leaf errors for readability
+					if len(leafErrors) > 3 {
+						leafErrors = leafErrors[len(leafErrors)-3:]
 					}
-				}
-				// fallback to generic message
-				if reason == "" {
-					reason = "multiple components failed validation"
+					reason = strings.Join(leafErrors, "; ")
 				}
 			}
+
+			// Fallback to Reason if no leaf errors extracted
+			if reason == "" {
+				reason = schemaErr.Reason
+			}
+
+			// Final fallback
+			if reason == "" {
+				reason = "schema validation failed"
+			}
 			res := model.RuleFunctionResult{
 				Message:   fmt.Sprintf("schema invalid: %v", reason),
 				StartNode: n,
@@ -214,10 +223,13 @@ func checkForNullableKeyword(context model.RuleFunctionContext) []model.RuleFunc
 	return results
 }
 
-// extractLeafValidationErrors extracts only leaf error messages from a jsonschema.ValidationError tree (issue #766)
+// extractLeafValidationErrors extracts only meaningful leaf error messages from a jsonschema.ValidationError tree (issue #766)
+// It filters out noise from oneOf/anyOf schema structures (like "missing properties: [$ref]")
 func extractLeafValidationErrors(err *jsonschema.ValidationError) []string {
-	var results []string
+	var highPriority []string  // Type errors, pattern errors, format errors - the real issues
+	var lowPriority []string   // Enum errors (often noise from oneOf branches)
 	seen := make(map[string]bool)
+	seenPaths := make(map[string]bool) // Track paths we've already reported errors for
 	const maxDepth = 50
 
 	var extract func(e *jsonschema.ValidationError, depth int)
@@ -229,12 +241,26 @@ func extractLeafValidationErrors(err *jsonschema.ValidationError) []string {
 		// if this is a leaf node (no causes), extract the message
 		if len(e.Causes) == 0 {
 			path := "/" + strings.Join(e.InstanceLocation, "/")
+
+			// Skip noise errors from oneOf/anyOf schema structures
+			if isNoiseError(e.ErrorKind) {
+				return
+			}
+
 			msg := errorKindToString(e.ErrorKind)
 			if msg != "" {
 				fullMsg := fmt.Sprintf("`%s` %s", path, msg)
 				if !seen[fullMsg] {
 					seen[fullMsg] = true
-					results = append(results, fullMsg)
+
+					// Categorize by priority
+					if isHighPriorityError(e.ErrorKind) {
+						highPriority = append(highPriority, fullMsg)
+						seenPaths[path] = true
+					} else if !seenPaths[path] {
+						// Only add low priority if we haven't seen this path in high priority
+						lowPriority = append(lowPriority, fullMsg)
+					}
 				}
 			}
 		}
@@ -246,7 +272,54 @@ func extractLeafValidationErrors(err *jsonschema.ValidationError) []string {
 	}
 
 	extract(err, 0)
-	return results
+
+	// Return high priority errors first, then low priority
+	if len(highPriority) > 0 {
+		return highPriority
+	}
+	return lowPriority
+}
+
+// isNoiseError returns true for errors that are noise from oneOf/anyOf schema structures
+func isNoiseError(ek jsonschema.ErrorKind) bool {
+	if ek == nil {
+		return true
+	}
+	switch k := ek.(type) {
+	case *kind.Required:
+		// "missing properties: [$ref]" is noise from oneOf branches in OpenAPI schemas
+		for _, missing := range k.Missing {
+			if missing == "$ref" {
+				return true
+			}
+		}
+	case *kind.FalseSchema:
+		// "property not allowed" from false schema branches
+		return true
+	}
+	return false
+}
+
+// isHighPriorityError returns true for errors that represent the actual root cause
+func isHighPriorityError(ek jsonschema.ErrorKind) bool {
+	if ek == nil {
+		return false
+	}
+	switch ek.(type) {
+	case *kind.Type:
+		return true // Wrong type is usually the real issue
+	case *kind.Pattern:
+		return true // Pattern mismatch is specific
+	case *kind.Format:
+		return true // Format error is specific
+	case *kind.Const:
+		return true // Const mismatch is specific
+	case *kind.AdditionalProperties:
+		return true // Extra properties is specific
+	case *kind.Required:
+		return true // Missing required field (that isn't $ref)
+	}
+	return false
 }
 
 // errorKindToString converts a jsonschema ErrorKind to a human-readable string

html-report/ui/package.json

@@ -20,22 +20,22 @@
     "@types/chart.js": "^2.9.37",
     "@typescript-eslint/eslint-plugin": "^5.38.1",
     "@typescript-eslint/parser": "^5.38.1",
-    "@web/dev-server-esbuild": "^0.3.3",
-    "@web/test-runner": "^0.15.1",
-    "@web/test-runner-commands": "^0.6.5",
-    "@web/test-runner-playwright": "^0.9.0",
-    "copy-webpack-plugin": "^11.0.0",
+    "@web/dev-server-esbuild": "^1.0.4",
+    "@web/test-runner": "^0.20.2",
+    "@web/test-runner-commands": "^0.9.0",
+    "@web/test-runner-playwright": "^0.11.1",
+    "copy-webpack-plugin": "^13.0.1",
     "eslint": "^8.23.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-lit-a11y": "^2.3.0",
     "eslint-plugin-wc": "^1.3.2",
-    "lint-staged": "^13.0.3",
+    "lint-staged": "^16.2.7",
     "mini-css-extract-plugin": "^2.6.1",
     "prettier": "^2.7.1",
     "webpack": "^5.74.0",
     "webpack-cli": "^5.0.1",
-    "webpack-dev-server": "^4.11.1"
+    "webpack-dev-server": "^5.2.2"
   },
   "dependencies": {
     "@open-wc/testing": "^3.1.7",

html-report/ui/tsconfig.json

@@ -12,5 +12,5 @@
   },
   "include": ["src/**/*.ts"],
   "exclude": ["node_modules", "./build",
-    "web-test-runner.config.mjs", "webpack.config.js"]
+    "web-test-runner.config.mjs", "webpack.config.js", "**/*.test.ts"]
 }

html-report/ui/webpack.config.js

@@ -17,7 +17,7 @@ module.exports = {
       {
         test: /\.tsx?$/,
         use: 'ts-loader',
-        exclude: /node_modules/,
+        exclude: [/node_modules/, /\.test\.ts$/],
       },
       {
         test: /\.css$/,