Skip to content

Commit 7a2985c

Browse files
committed
Fix formatting for space indented mode
1 parent 1ba511b commit 7a2985c

File tree

3 files changed

+29
-35
lines changed

3 files changed

+29
-35
lines changed

examples/no-indent.stdout

+12-29
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,21 @@
1-
1:main no_indent::hierarchical-example
2-
1:main version=0.1
3-
1:main no_indent::server
4-
1:main host="localhost"
5-
1:main port=8080
1+
1:main no_indent::hierarchical-example version=0.1
2+
1:main no_indent::server host="localhost", port=8080
63
1:main INFO no_indent starting
74
1:main INFO no_indent listening
8-
1:main no_indent::conn
9-
1:main peer_addr="82.9.9.9"
10-
1:main port=42381
5+
1:main no_indent::conn peer_addr="82.9.9.9", port=42381
116
1:main DEBUG no_indent connected
12-
1:main DEBUG no_indent message received
13-
1:main length=2
14-
1:main no_indent::conn
15-
1:main peer_addr="8.8.8.8"
16-
1:main port=18230
7+
1:main DEBUG no_indent message received, length=2
8+
1:main no_indent::conn peer_addr="8.8.8.8", port=18230
179
1:main DEBUG no_indent connected
18-
1:main no_indent::foomp 42 <- format string
19-
1:main normal_var=43
10+
1:main no_indent::foomp 42 <- format string, normal_var=43
2011
1:main ERROR no_indent hello
21-
1:main no_indent::conn
22-
1:main peer_addr="82.9.9.9"
23-
1:main port=42381
24-
1:main WARN no_indent weak encryption requested
25-
1:main algo="xor"
26-
1:main DEBUG no_indent response sent
27-
1:main length=8
12+
1:main no_indent::conn peer_addr="82.9.9.9", port=42381
13+
1:main WARN no_indent weak encryption requested, algo="xor"
14+
1:main DEBUG no_indent response sent, length=8
2815
1:main DEBUG no_indent disconnected
29-
1:main no_indent::conn
30-
1:main peer_addr="8.8.8.8"
31-
1:main port=18230
32-
1:main DEBUG no_indent message received
33-
1:main length=5
34-
1:main DEBUG no_indent response sent
35-
1:main length=8
16+
1:main no_indent::conn peer_addr="8.8.8.8", port=18230
17+
1:main DEBUG no_indent message received, length=5
18+
1:main DEBUG no_indent response sent, length=8
3619
1:main DEBUG no_indent disconnected
3720
1:main WARN no_indent internal error
3821
1:main INFO no_indent exit

src/format.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ impl Buffers {
272272

273273
pub struct FmtEvent<'a> {
274274
pub bufs: &'a mut Buffers,
275+
pub lines: bool,
275276
}
276277

277278
impl<'a> Visit for FmtEvent<'a> {
@@ -285,7 +286,12 @@ impl<'a> Visit for FmtEvent<'a> {
285286
#[cfg(feature = "tracing-log")]
286287
name if name.starts_with("log.") => {}
287288
name => {
288-
write!(buf, "\n {}={:?}", name, value).unwrap();
289+
if self.lines {
290+
write!(buf, "\n ").unwrap()
291+
} else {
292+
write!(buf, ", ").unwrap()
293+
}
294+
write!(buf, "{}={:?}", name, value).unwrap();
289295
}
290296
}
291297
}

src/lib.rs

+10-5
Original file line numberDiff line numberDiff line change
@@ -246,16 +246,18 @@ where
246246
V: fmt::Display + 'a,
247247
{
248248
let mut kvs = kvs.into_iter();
249-
let nl = if self.config.bracketed_fields {
250-
""
249+
let (nl, first) = if self.config.bracketed_fields {
250+
("", "")
251+
} else if self.config.indent_lines {
252+
("\n ", "\n ")
251253
} else {
252-
"\n "
254+
(", ", " ")
253255
};
254256
if let Some((k, v)) = kvs.next() {
255257
if k == "message" {
256258
write!(buf, " {}", v)?;
257259
} else {
258-
write!(buf, "{nl}{}={}", k, v)?;
260+
write!(buf, "{first}{}={}", k, v)?;
259261
}
260262
}
261263
for (k, v) in kvs {
@@ -560,7 +562,10 @@ where
560562
.expect("Unable to write to buffer");
561563
}
562564

563-
let mut visitor = FmtEvent { bufs };
565+
let mut visitor = FmtEvent {
566+
bufs,
567+
lines: self.config.indent_lines,
568+
};
564569
event.record(&mut visitor);
565570
visitor
566571
.bufs

0 commit comments

Comments
 (0)