Skip to content

Commit 47b72fa

Browse files
committed
refactor(ssh): delay loading of tunnel-ssh and improve load time
This improves the loadtime of db-migrate by 47%. To be exact from ~22ms to ~15ms. Resolves #387
1 parent 3fca510 commit 47b72fa

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

lib/driver/index.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ internals.mod.log = require('db-migrate-shared').log;
55
internals.mod.type = require('db-migrate-shared').dataType;
66
var Shadow = require('./shadow');
77
var log = internals.mod.log;
8-
var tunnel = require('tunnel-ssh'),
9-
Promise = require('bluebird'),
8+
var Promise = require('bluebird'),
109
SeederInterface = require('../interface/seederInterface.js'),
1110
MigratorInterface = require('../interface/migratorInterface.js'),
1211
resolve = require( 'resolve' );
@@ -119,6 +118,7 @@ exports.connect = function (config, intern, callback) {
119118
};
120119

121120
if (config.tunnel) {
121+
var tunnel = require('tunnel-ssh');
122122
var tunnelConfig = JSON.parse(JSON.stringify(config.tunnel));
123123
tunnelConfig.dstHost = config.host;
124124
tunnelConfig.dstPort = config.port;
@@ -132,7 +132,6 @@ exports.connect = function (config, intern, callback) {
132132
config.port = tunnelConfig.localPort;
133133

134134
tunnel(tunnelConfig, function (err) {
135-
136135
if (err) {
137136
callback(err);
138137
return;

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"pkginfo": "~0.3.0",
5757
"resolve": "^1.1.6",
5858
"semver": "~5.1.0",
59-
"tunnel-ssh": "^2.0.0"
59+
"tunnel-ssh": "^4.0.0"
6060
},
6161
"devDependencies": {
6262
"code": "^1.3.0",

0 commit comments

Comments
 (0)