Skip to content

Commit 3d4331c

Browse files
authored
Merge pull request brucefan1983#1041 from brucefan1983/ti-liquid-bug-fix
TI-liquid sym bug fixed
2 parents 728fb10 + 875a9a7 commit 3d4331c

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

src/integrate/ensemble_ti_liquid.cu

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,9 @@ static __global__ void calc_UF_force(
8686
tmp_fz_UF = z12 * factor;
8787
eUF_i -= p / beta * logf(1 - exp(-d12_sqrd / sigma_sqrd));
8888

89-
fx_UF[i] += tmp_fx_UF / 2;
90-
fx_UF[n2] -= tmp_fx_UF / 2;
91-
92-
fy_UF[i] += tmp_fy_UF / 2;
93-
fy_UF[n2] -= tmp_fy_UF / 2;
94-
95-
fz_UF[i] += tmp_fz_UF / 2;
96-
fz_UF[n2] -= tmp_fz_UF / 2;
89+
fx_UF[i] += tmp_fx_UF;
90+
fy_UF[i] += tmp_fy_UF;
91+
fz_UF[i] += tmp_fz_UF;
9792
}
9893

9994
eUF[i] = eUF_i / 2;
@@ -189,6 +184,10 @@ Ensemble_TI_Liquid::Ensemble_TI_Liquid(const char** params, int num_params)
189184
} else if (strcmp(params[i], "p") == 0) {
190185
if (!is_valid_real(params[i + 1], &p))
191186
PRINT_INPUT_ERROR("Wrong inputs for p keyword.");
187+
188+
if (p != 1 && p != 25 && p != 50 && p != 75 && p != 100)
189+
PRINT_INPUT_ERROR("Please pick p equal to 1, 25, 50, 75 or 100.");
190+
192191
i += 2;
193192
} else {
194193
PRINT_INPUT_ERROR("Unknown keyword.");
@@ -350,20 +349,13 @@ Ensemble_TI_Liquid::~Ensemble_TI_Liquid(void)
350349
for (const auto& entry : species_count) {
351350
int count = entry.second;
352351
double cn = static_cast<double>(count) / N;
353-
printf("cn: %f\n", cn);
352+
354353
if (cn > 0) {
355354
c_sum += cn * log(cn);
356355
}
357356
}
358357

359-
printf("de broigle %f\n", de_broigle_sum);
360-
printf("c_sum %f\n", c_sum);
361-
362-
printf("rho: %f\n", 1 / V);
363-
364358
double F_IG = N * kT * (log(1 / V) - 1 + c_sum) + 3 * kT * de_broigle_sum;
365-
printf("F_IG / N: %f\n", F_IG / N);
366-
printf("F_UF / N: %f\n", F_UF / N);
367359
E_ref = (F_UF + F_IG) / N;
368360

369361
FILE* yaml_file = my_fopen("ti_liquid.yaml", "w");

0 commit comments

Comments
 (0)