Fix reading assembly store hashes in AssemblyStoreReader

vaind · web-flow · commit c03c953a71e1 · 2022-11-30T10:15:29.000Z
The 64-bit hashes were mistakenly read as 32-bit ones.
Fix the issue by passing the correct value of the `is32Bit` 
flag to the reader method.
diff --git a/tools/assembly-store-reader/AssemblyStoreReader.cs b/tools/assembly-store-reader/AssemblyStoreReader.cs
@@ -172,7 +172,7 @@ void ReadLocalEntries (BinaryReader reader, List<AssemblyStoreAssembly> assembli
 		void ReadGlobalIndex (BinaryReader reader, List<AssemblyStoreHashEntry> index32, List<AssemblyStoreHashEntry> index64)
 		{
 			ReadIndex (true, index32);
-			ReadIndex (true, index64);
+			ReadIndex (false, index64);
 
 			void ReadIndex (bool is32Bit, List<AssemblyStoreHashEntry> index) {
 				for (uint i = 0; i < GlobalEntryCount; i++) {

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ void ReadLocalEntries (BinaryReader reader, List<AssemblyStoreAssembly> assembli`
`172`	`172`	`void ReadGlobalIndex (BinaryReader reader, List<AssemblyStoreHashEntry> index32, List<AssemblyStoreHashEntry> index64)`
`173`	`173`	`{`
`174`	`174`	`ReadIndex (true, index32);`
`175`		`- ReadIndex (true, index64);`
	`175`	`+ ReadIndex (false, index64);`
`176`	`176`
`177`	`177`	`void ReadIndex (bool is32Bit, List<AssemblyStoreHashEntry> index) {`
`178`	`178`	`for (uint i = 0; i < GlobalEntryCount; i++) {`