[pre-commit ruff] Align the entire repo with ruff (#29603)

* Fix falls of the ruff hook

* pre-commit

* Fix B003 ruff error

* Fix ruff errors on Utils/update_playbook.py

Author: mmhw

Packs/CimTrak-SystemIntegrityAssurance/Integrations/CimTrak/CimTrak_test.py

@@ -14,14 +14,13 @@
 """
 
 import json
-import io
 import logging
 
 LOGGER = logging.getLogger(__name__)
 
 
 def util_load_json(path):
-    with io.open(path, mode="r", encoding="utf-8") as f:
+    with open(path, encoding="utf-8") as f:
         return json.loads(f.read())
 
 
@@ -45,7 +44,7 @@ def test_cimtrak(requests_mock):
         pre_script += "    }\n"
         pre_script += ")\n"
 
-        exec(pre_script + test_json["execute"], globals())
+        exec(pre_script + test_json["execute"], globals())  # noqa: S102
         dict_expected_result = test_json["response"]
         dict_actual_result = response
 

Utils/_script_docker_python_loop_example.py

@@ -448,7 +448,7 @@ def do_ping_pong():
 
 
 def rollback_system():
-    os.environ = {}
+    os.environ.clear()
     for key in backup_env_vars:
         os.environ[key] = backup_env_vars[key]
 
@@ -480,7 +480,7 @@ def rollback_system():
             'win': win
         }
 
-        exec(code, sub_globals, sub_globals)  # guardrails-disable-line  # pylint: disable=W0122
+        exec(code, sub_globals, sub_globals)  # guardrails-disable-line  # pylint: disable=W0122 # noqa: S102
 
     except Exception:
         exc_type, exc_value, exc_traceback = sys.exc_info()

Utils/update_playbook.py

@@ -1,3 +1,4 @@
+import logging
 import sys
 import ntpath
 import yaml
@@ -26,7 +27,7 @@ def update_playbook_task_name(playbook):
     :param playbook: playbook dict loaded from yaml
     :return: updated playbook dict
     """
-    for task_id, task in playbook.get("tasks", {}).items():
+    for _task_id, task in playbook.get("tasks", {}).items():
         if task.get("type") == "playbook":
             task["task"]["name"] = task["task"]["playbookName"]
 
@@ -92,10 +93,10 @@ def update_replace_copy_dev(playbook):
 
 
 def update_playbook(source_path, destination_path):
-    print("Starting...")
+    logging.info("Starting...")
 
     with open(source_path) as f:
-        playbook = yaml.load(f, Loader=yamlordereddictloader.SafeLoader)
+        playbook = yaml.safe_load(f)
 
     playbook = update_replace_copy_dev(playbook)
 
@@ -114,14 +115,14 @@ def update_playbook(source_path, destination_path):
         destination_path = ntpath.basename(source_path)
 
     if not destination_path.startswith("playbook-"):
-        destination_path = "playbook-{}".format(destination_path)
+        destination_path = f"playbook-{destination_path}"
 
     # Configure safe dumper (multiline for strings)
     yaml.SafeDumper.org_represent_str = yaml.SafeDumper.represent_str  # type: ignore[attr-defined]
 
     def repr_str(dumper, data):
         if '\n' in data:
-            return dumper.represent_scalar(u'tag:yaml.org,2002:str', data, style='|')
+            return dumper.represent_scalar('tag:yaml.org,2002:str', data, style='|')
         return dumper.org_represent_str(data)
     yaml.add_representer(str, repr_str, Dumper=yamlordereddictloader.SafeDumper)
 
@@ -132,12 +133,12 @@ def repr_str(dumper, data):
             Dumper=yamlordereddictloader.SafeDumper,
             default_flow_style=False)
 
-    print("Finished - new yml saved at {}".format(destination_path))
+    logging.info(f"Finished - new yml saved at {destination_path}")
 
 
 def main(argv):
     if len(argv) < 1:
-        print("Please provide <source playbook path>, <optional - destination playbook path>")
+        logging.info("Please provide <source playbook path>, <optional - destination playbook path>")
         sys.exit(1)
 
     source_path = argv[0]