Bug Jira - get-issue with attachment wrong url #17670

MLainer1 · 2022-02-15T09:07:47Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: https://github.com/demisto/etc/issues/46579

Description

Wrong url when trying to get attachment of an issue when calling command get-issue

Minimum version of Cortex XSOAR

6.0.0
6.1.0
6.2.0
6.5.0

Does it break backward compatibility?

Yes
- Further details:
No

Must have

Tests
Documentation

jochman

Is that a bug in the integration or a change of the api?

jochman · 2022-02-15T16:18:25Z

Packs/Jira/Integrations/JiraV2/JiraV2_test.py

+    requests_mock.get('https://localhost/rest/api/latest/issue/VIK-267', json=GET_ISSUE_WITH_ATTACHMENT_RESPONSE)
+    requests_mock.get('https://localhost/rest/api/2/attachment/content/16188', json={})
+
+    get_issue("VIK-267", get_attachments="true")  # the command will fail if not doing a request with the proper url


Suggested change

get_issue("VIK-267", get_attachments="true") # the command will fail if not doing a request with the proper url

assert get_issue("VIK-267", get_attachments="true"), 'There was a request to the wrong url'

Much clearer when fails.

jochman · 2022-02-15T16:18:44Z

Packs/Jira/Integrations/JiraV2/JiraV2_test.py

+def test_get_issue_attachment_url(mocker, requests_mock):
+    """
+    Given:
+        - The issue ID.


This is not describing what you're testing.

jochman · 2022-02-15T16:19:25Z

Packs/Jira/Integrations/JiraV2/JiraV2_test.py

@@ -1282,3 +1282,23 @@ def test_get_custom_field_names(mocker, requests_mock):
    requests_mock.get('https://localhost/rest/api/latest/field', json=FIELDS_RESPONSE)
    res = get_custom_field_names()
    assert res == EXPECTED_RESP
+
+
+def test_get_issue_attachment_url(mocker, requests_mock):


Call the function in a describable name.

jochman · 2022-02-15T16:21:39Z

Packs/Jira/Integrations/JiraV2/JiraV2.py

@@ -673,7 +673,7 @@ def get_issue(issue_id, headers=None, expand_links=False, is_update=False, get_a
    if get_attachments and attachments:
        attachment_urls = [attachment['content'] for attachment in attachments]
        for attachment_url in attachment_urls:
-            attachment = f"secure{attachment_url.split('/secure')[-1]}"
+            attachment = f"rest{attachment_url.split('/rest')[-1]}"


What happens here?
I suggest you extract it into a new function and test it with input/output so other developers can see what you're doing here.

jochman

ok

avidan-H · 2022-02-17T09:53:01Z

Packs/Jira/Integrations/JiraV2/test_data/raw_response.py

+               'aggregatetimeestimate': None, 'summary': 'test master1',
               'creator': {
-                    "accountId": "557058:fb80ffc0-b374-4260-99a0-ea0c140a4e76",
-                    "accountType": "atlassian",
-                    "active": True,
-                    "avatarUrls": {
-                        "16x16": "",
-                        "24x24": "",
-                        "32x32": "",
-                        "48x48": ""
-                    },
-                    "displayName": "jon doe",
-                    "emailAddress": "[email protected]",
-                    "self": "https://demistodev.atlassian.net/rest/api/2/user?accountId=id",
-                    "timeZone": "Asia"
-                }
-    }
+                   "accountId": "557058:fb80ffc0-b374-4260-99a0-ea0c140a4e76",
+                   "accountType": "atlassian",
+                   "active": True,
+                   "avatarUrls": {
+                       "16x16": "",
+                       "24x24": "",
+                       "32x32": "",
+                       "48x48": ""
+                   },
+                   "displayName": "jon doe",
+                   "emailAddress": "[email protected]",
+                   "self": "https://demistodev.atlassian.net/rest/api/2/user?accountId=id",
+                   "timeZone": "Asia"


Be consistent with your quotation marks. They should either all be single quotes or double quotes - not a mixture of the two. The 'soon-to-be' official recommendation (it hasn't yet been added to the development conventions in the development docs yet) is to use single quotes.

avidan-H · 2022-02-17T09:53:31Z

Packs/Jira/Integrations/JiraV2/test_data/raw_response.py

+                   "self": "https://demistodev.atlassian.net/rest/api/2/user?accountId=id",
+                   "timeZone": "Asia"
+               }
+               }


This bracket's placement is misformatted.

avidan-H · 2022-02-17T09:54:56Z

Packs/Jira/ReleaseNotes/1_4_8.md

+
+#### Integrations
+##### Atlassian Jira v2
+- Fixed an issue where calling the command **get-issue** with *getAttachments="true"* returned an error.


Suggested change

- Fixed an issue where calling the command **get-issue** with *getAttachments="true"* returned an error.

- Fixed an issue where calling the **get-issue** command with *getAttachments="true"* caused an error.

avidan-H · 2022-02-17T10:32:25Z

Packs/Jira/Integrations/JiraV2/test_data/raw_response.py

+                'emailAddress': '[email protected]',
+                'avatarUrls': {
+                    '48x48': ''},
+                'displayName': 'Meir Wahnon', 'active': True, 'timeZone': 'Asia/Jerusalem',
+                'accountType': 'atlassian'},
+             'created': '2021-04-04T12:49:42.881+0300', 'size': 8225,
+             'mimeType': 'application/json',
+             }],
+        'aggregatetimeestimate': None, 'summary': 'test master1',
+        'creator': {
+            'accountId': '557058:fb80ffc0-b374-4260-99a0-ea0c140a4e76',
+            'accountType': 'atlassian',
+            'active': True,
+            'avatarUrls': {
+                '16x16': '',
+                '24x24': '',
+                '32x32': '',
+                '48x48': ''
+            },
+            'displayName': 'jon doe',
+            'emailAddress': '[email protected]',
+            'self': 'https://demistodev.atlassian.net/rest/api/2/user?accountId=id',
+            'timeZone': 'Asia'


Looks like some of this info is real(ish)... make sure to use fake information.

content-bot · 2022-02-20T09:47:56Z

Link to the unit tests coverage report:
https://xsoar.docs.pan.run/-/content/-/jobs/10925405/artifacts/artifacts/coverage_report/html/index.html

MLainer1 added 2 commits February 15, 2022 10:53

failed test

1f28c57

failed test

fbbc86b

MLainer1 requested a review from a team as a code owner February 15, 2022 09:07

MLainer1 changed the title ~~Bug Jira - Get issue with attachment wrong url~~ Bug Jira - get-issue with attachment wrong url Feb 15, 2022

MLainer1 added 2 commits February 15, 2022 11:58

possible solution

9c9d627

Merge branch 'master' into Bug_Jira

1768a6a

bakatzir requested a review from ShacharKidor February 15, 2022 10:41

MLainer1 added 3 commits February 15, 2022 13:48

possible solution

91c2d87

Merge branch 'master' into Bug_Jira

9d890e9

release notes and metadata

5106750

MLainer1 requested review from jochman and removed request for a team February 15, 2022 12:57

MLainer1 assigned amshamah419 Feb 15, 2022

MLainer1 added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Feb 15, 2022

jochman suggested changes Feb 15, 2022

View reviewed changes

ShacharKidor approved these changes Feb 16, 2022

View reviewed changes

MLainer1 added 4 commits February 16, 2022 15:55

changes after cr

2607032

Merge branch 'master' into Bug_Jira

f48672e

removed uneeded raw response

cc15681

updated tests

b834be7

MLainer1 requested a review from jochman February 16, 2022 15:35

jochman approved these changes Feb 16, 2022

View reviewed changes

MLainer1 unassigned amshamah419 Feb 17, 2022

MLainer1 requested a review from avidan-H February 17, 2022 08:46

avidan-H suggested changes Feb 17, 2022

View reviewed changes

MLainer1 added 2 commits February 17, 2022 12:22

changes after cr

a854a30

Merge branch 'master' into Bug_Jira

623acb8

avidan-H suggested changes Feb 17, 2022

View reviewed changes

MLainer1 added the docs-approved label Feb 17, 2022

updated raw response

df483bf

MLainer1 removed the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Feb 17, 2022

MLainer1 requested a review from avidan-H February 17, 2022 12:49

MLainer1 added 2 commits February 20, 2022 11:33

removed sensitive data

2ca6a80

Merge branch 'master' into Bug_Jira

013b06a

avidan-H approved these changes Feb 20, 2022

View reviewed changes

MLainer1 merged commit 40ea26a into master Feb 20, 2022

MLainer1 deleted the Bug_Jira branch February 20, 2022 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bug Jira - get-issue with attachment wrong url #17670

Bug Jira - get-issue with attachment wrong url #17670

Uh oh!

MLainer1 commented Feb 15, 2022 •

edited

Loading

Uh oh!

jochman left a comment

Uh oh!

jochman Feb 15, 2022

Uh oh!

jochman Feb 15, 2022

Uh oh!

jochman Feb 15, 2022

Uh oh!

jochman Feb 15, 2022

Uh oh!

jochman left a comment

Uh oh!

avidan-H Feb 17, 2022

Uh oh!

avidan-H Feb 17, 2022

Uh oh!

avidan-H Feb 17, 2022

Uh oh!

avidan-H Feb 17, 2022

Uh oh!

content-bot commented Feb 20, 2022

Uh oh!

Uh oh!

	get_issue("VIK-267", get_attachments="true") # the command will fail if not doing a request with the proper url
	assert get_issue("VIK-267", get_attachments="true"), 'There was a request to the wrong url'

	- Fixed an issue where calling the command get-issue with getAttachments="true" returned an error.
	- Fixed an issue where calling the get-issue command with getAttachments="true" caused an error.

Bug Jira - get-issue with attachment wrong url #17670

Bug Jira - get-issue with attachment wrong url #17670

Uh oh!

Conversation

MLainer1 commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Minimum version of Cortex XSOAR

Does it break backward compatibility?

Must have

Uh oh!

jochman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jochman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

content-bot commented Feb 20, 2022

Uh oh!

Uh oh!

MLainer1 commented Feb 15, 2022 •

edited

Loading