Wildfire support ootb license #17675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on 6.2 machine, 6.5 machine and a new testing machine. |
yaakovi
approved these changes
Feb 15, 2022
anara123
reviewed
Feb 15, 2022
| @@ -11,6 +11,12 @@ | |||
| PARAMS = demisto.params() | |||
| URL = PARAMS.get('server') | |||
| TOKEN = PARAMS.get('token') or (PARAMS.get('credentials') or {}).get('password') | |||
| if not TOKEN and is_demisto_version_ge('6.5.0'): | |||
There was a problem hiding this comment.
Suggested change
| if not TOKEN and is_demisto_version_ge('6.5.0'): | |
| if not TOKEN and is_demisto_version_ge('6.6.0'): |
|
Link to the unit tests coverage report: |
yuvalbenshalom
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://github.com/demisto/etc/issues/45358
Description
Added support for license based / config based retrieval of the API token.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have