Skip to content

[McAfeeNSMv2] MyPy In Docker #37995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 13, 2025
Merged

[McAfeeNSMv2] MyPy In Docker #37995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52a6c94
fix
shmuel44 Jan 8, 2025
6b305f5
fix
shmuel44 Jan 8, 2025
d24b775
RN
shmuel44 Jan 8, 2025
efdb6ed
E501 Line too long
shmuel44 Jan 8, 2025
6b8d9bd
autopep8
shmuel44 Jan 8, 2025
28b0bd9
Merge branch 'master' into sk_McAfeeNSMv2_mypy
shmuel44 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Packs/McAfeeNSM/Integrations/McAfeeNSMv2/McAfeeNSMv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,9 +1323,20 @@ def update_firewall_policy_command(client: Client, args: dict) -> CommandResults
destination_object = update_source_destination_object(destination_object, destination_rule_object_id,
destination_rule_object_type)

body = create_body_firewall_policy(domain, name, visible_to_child, description, is_editable, policy_type,
rule_description, response_param, rule_enabled, direction, source_object,
destination_object)
body = create_body_firewall_policy(
domain, # type: ignore[arg-type]
name, # type: ignore[arg-type]
visible_to_child, # type: ignore[arg-type]
description, # type: ignore[arg-type]
is_editable, # type: ignore[arg-type]
policy_type, # type: ignore[arg-type]
rule_description,
response_param,
rule_enabled,
direction,
source_object,
destination_object
)

client.update_firewall_policy_request(body, policy_id)
return CommandResults(readable_output=f'The firewall policy no.{policy_id} was updated successfully')
Expand Down Expand Up @@ -1463,7 +1474,7 @@ def create_rule_object_command(client: Client, args: dict) -> CommandResults:
from_address = from_address_ip_v_4 if from_address_ip_v_4 else from_address_ip_v_6
to_address = to_address_ip_v_4 if to_address_ip_v_4 else to_address_ip_v_6

check_args_create_rule(rule_type, address, from_address, to_address, number)
check_args_create_rule(rule_type, address, from_address, to_address, number) # type: ignore[arg-type]

body = {
'RuleObjDef': {
Expand Down
2 changes: 1 addition & 1 deletion Packs/McAfeeNSM/Integrations/McAfeeNSMv2/McAfeeNSMv2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,7 @@ script:
script: '-'
type: python
subtype: python3
dockerimage: demisto/python3:3.11.10.115186
dockerimage: demisto/python3:3.11.11.1940698
fromversion: 6.5.0
tests:
- Test_McAfeeNSMv2_using_v9
Expand Down
6 changes: 6 additions & 0 deletions Packs/McAfeeNSM/ReleaseNotes/1_2_20.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### McAfee NSM v2

Updated the Docker image to: *demisto/python3:3.11.11.1940698*.
2 changes: 1 addition & 1 deletion Packs/McAfeeNSM/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "McAfee NSM",
"description": "McAfee Network Security Manager",
"support": "xsoar",
"currentVersion": "1.2.19",
"currentVersion": "1.2.20",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
Loading